From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zmg22-0007ge-RI for barebox@lists.infradead.org; Thu, 15 Oct 2015 10:45:11 +0000 Date: Thu, 15 Oct 2015 12:44:48 +0200 From: Sascha Hauer Message-ID: <20151015104448.GX7858@pengutronix.de> References: <1444897136-25028-1-git-send-email-s.hauer@pengutronix.de> <1444897136-25028-3-git-send-email-s.hauer@pengutronix.de> <20151015110037.7bfef9ab@free-electrons.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151015110037.7bfef9ab@free-electrons.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/3] scripts/kwbimage: Make BINARY files relative to config file To: Thomas Petazzoni Cc: Barebox List On Thu, Oct 15, 2015 at 11:00:37AM +0200, Thomas Petazzoni wrote: > Sascha, > > On Thu, 15 Oct 2015 10:18:55 +0200, Sascha Hauer wrote: > > The BINARY files given in the config files are expected to be relative > > to the place kwbimage is called from. This is bad since it breaks where > > kwbimage is called from the build directory and not the source > > directory. > > It makes more sense to make the paths in the config files relative > > to the config files which works with out of tree builds and is also > > more what a user normally expects. > > > > Signed-off-by: Sascha Hauer > > In practice those binary.0 files are not really part of the Barebox > source code. The binary.0 file has to be extracted from a vendor U-Boot > binary prior to doing the Barebox build, so it isn't exactly part of > the "source tree". Yes, right. > > Though I agree it is probably easier to extract them once and keep them > around in the source tree (not checked-in, of course). I think this aswell. The build tree often is deleted, but then the binary.0 images should still be available. > > Note that U-Boot now has a fully open-source implementation of this > binary.0 thing, at least for Armada XP and Armada 38x. However, it's > basically copy/pasted from the vendor U-Boot, so it's not very pretty > to look at: > > - http://git.denx.de/?p=u-boot.git;a=tree;f=drivers/ddr/marvell > for the DDR initialization code. Nice to have, indeed not nice to look at. This code is huge... Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox