From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zo47O-0004Z4-Ts for barebox@lists.infradead.org; Mon, 19 Oct 2015 06:40:28 +0000 Date: Mon, 19 Oct 2015 08:40:04 +0200 From: Sascha Hauer Message-ID: <20151019064004.GD14476@pengutronix.de> References: <1444897136-25028-1-git-send-email-s.hauer@pengutronix.de> <1444897136-25028-3-git-send-email-s.hauer@pengutronix.de> <20151015110037.7bfef9ab@free-electrons.com> <561F7212.1010205@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <561F7212.1010205@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/3] scripts/kwbimage: Make BINARY files relative to config file To: Sebastian Hesselbarth Cc: Thomas Petazzoni , Barebox List On Thu, Oct 15, 2015 at 11:29:54AM +0200, Sebastian Hesselbarth wrote: > On 15.10.2015 11:00, Thomas Petazzoni wrote: > >On Thu, 15 Oct 2015 10:18:55 +0200, Sascha Hauer wrote: > >>The BINARY files given in the config files are expected to be relative > >>to the place kwbimage is called from. This is bad since it breaks where > >>kwbimage is called from the build directory and not the source > >>directory. > >>It makes more sense to make the paths in the config files relative > >>to the config files which works with out of tree builds and is also > >>more what a user normally expects. > >> > >>Signed-off-by: Sascha Hauer > > > >In practice those binary.0 files are not really part of the Barebox > >source code. The binary.0 file has to be extracted from a vendor U-Boot > >binary prior to doing the Barebox build, so it isn't exactly part of > >the "source tree". > > > >Though I agree it is probably easier to extract them once and keep them > >around in the source tree (not checked-in, of course). > > Sascha, > > I am fine with making the path relative to kwbimage.cfg, although I'd > make it even more explicit by putting a './' in from of the binary.0 > in each kwbimage.cfg. I added the './' and applied the series to next. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox