mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Eric Nelson <eric@nelint.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] imx6-mmdc: fix automatic power down enable in write level calibration
Date: Mon, 26 Oct 2015 07:53:31 +0100	[thread overview]
Message-ID: <20151026065331.GS14476@pengutronix.de> (raw)
In-Reply-To: <1445629784-2024-1-git-send-email-eric@nelint.com>

Hi Eric,

On Fri, Oct 23, 2015 at 12:49:44PM -0700, Eric Nelson wrote:
> Bit 0 of the MAPSR register controls auto power down.
> 
> Explicitly clear this bit instead of reserved bit when
> exiting from mmdc_do_write_level_calibration().
> 
> Signed-off-by: Eric Nelson <eric@nelint.com>

Looks good, applied. Did this bug have any practical impacts?

Sascha

> ---
>  arch/arm/mach-imx/imx6-mmdc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/imx6-mmdc.c b/arch/arm/mach-imx/imx6-mmdc.c
> index 64fb624..40fe0cf 100644
> --- a/arch/arm/mach-imx/imx6-mmdc.c
> +++ b/arch/arm/mach-imx/imx6-mmdc.c
> @@ -103,9 +103,9 @@ int mmdc_do_write_level_calibration(void)
>  	val |= 0x00005500;
>  	writel(val, (P0_IPS + MDPDC));
>  
> -	/* enable Adopt power down timer: */
> +	/* enable auto power down timer: */
>  	val = readl(P0_IPS + MAPSR);
> -	val &= 0xfffffff7;
> +	val &= ~1;
>  	writel(val, (P0_IPS + MAPSR));
>  
>  	/* clear CON_REQ */
> -- 
> 2.6.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-10-26  6:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 19:49 Eric Nelson
2015-10-26  6:53 ` Sascha Hauer [this message]
2015-10-26 14:07   ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151026065331.GS14476@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eric@nelint.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox