From: Juergen Borleis <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Peter Mamonov <pmamonov@gmail.com>
Subject: Re: [BUG] ata: disk_ata_drive: SSD drive doesn't pass check for ata id validity
Date: Fri, 30 Oct 2015 09:53:50 +0100 [thread overview]
Message-ID: <201510300953.50440.jbe@pengutronix.de> (raw)
In-Reply-To: <20151030073104.GZ25308@pengutronix.de>
On Friday 30 October 2015 08:31:04 Sascha Hauer wrote:
> On Thu, Oct 29, 2015 at 04:04:09PM +0300, Peter Mamonov wrote:
> > Hi!
> >
> > Barebox refuses to deal with OCZ-VERTEX4 ssd sata drive, because:
> > ata1: ata id invalid
> >
> > This error is triggered by the following piece of code :
> >
> > static int ata_id_is_valid(const uint16_t *id)
> > {
> > if ((id[ATA_ID_FIELD_VALID] & 1) == 0) {
> > pr_debug("Drive's ID seems invalid\n");
> > return -EINVAL;
> > }
> >
> > return 0;
> > }
> >
> > The "id" is a sector-sized block of bytes, received after
> > issuing ATA_CMD_ID_ATA command.
> >
> > If I remove this check, the drive works fine.
> >
> > Can someone with better knowledge of ATA standard comment on this
> > issue?
>
> Juergen, do you have an idea what this check is for? Neither U-Boot nor
> the Kernel seem to ever check for bit 0 in this field.
Seems this bit was meaningful in earlier days: it marked the ID member in the
structure returned by the disk as valid (=1) or invalid (=0). In the meantime
it seems obsolete. The last occurrence I found is in the Linux kernel in
file "drivers/block/mg_disk.c". All other code which checks this register
content just check bits 1 and 2. I vote for removing this piece of code.
jbe
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-10-30 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 13:04 Peter Mamonov
2015-10-30 7:31 ` Sascha Hauer
2015-10-30 8:53 ` Juergen Borleis [this message]
2015-10-30 10:06 ` Peter Mamonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201510300953.50440.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox