mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sergey Koshechkin <tritel59@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] login: make some locally used functions static
Date: Sun, 1 Nov 2015 09:12:58 +0300	[thread overview]
Message-ID: <20151101091258.42b5fa76f90ea1e9dee76ffe@gmail.com> (raw)
In-Reply-To: <1446209700-21282-1-git-send-email-tritel59@gmail.com>

On Fri, 30 Oct 2015 15:55:00 +0300
Sergey Koshechkin <tritel59@gmail.com> wrote:

> This patch continues cleanup password code from
> 
>   commit 40596b856f61c281fb34f804bf42550c099f26c3
>   Author: Sascha Hauer <s.hauer@pengutronix.de>
>   Date:   Thu Aug 27 15:58:50 2015 +0200
> 
>       login: cleanup password code


... and this patch fixes some 'no previous prototype' warnings:

common/password.c:114:5: warning: no previous prototype for ‘is_passwd_default_enable’ [-Wmissing-prototypes]
 int is_passwd_default_enable(void)
     ^
common/password.c:120:5: warning: no previous prototype for ‘is_passwd_env_enable’ [-Wmissing-prototypes]
 int is_passwd_env_enable(void)
     ^
common/password.c:230:5: warning: no previous prototype for ‘write_env_passwd’ [-Wmissing-prototypes]
 int write_env_passwd(unsigned char *sum, size_t length)
     ^

> 
> Signed-off-by: Sergey Koshechkin <tritel59@gmail.com>
> ---
>  common/password.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/common/password.c b/common/password.c
> index b5b7655..5b754d9 100644
> --- a/common/password.c
> +++ b/common/password.c
> @@ -111,13 +111,12 @@ int password(unsigned char *passwd, size_t length, int flags, int timeout)
>  }
>  EXPORT_SYMBOL(password);
>  
> -int is_passwd_default_enable(void)
> +static int is_passwd_default_enable(void)
>  {
>  	return strlen(default_passwd) > 0;
>  }
> -EXPORT_SYMBOL(is_passwd_default_enable);
>  
> -int is_passwd_env_enable(void)
> +static int is_passwd_env_enable(void)
>  {
>  	int fd;
>  
> @@ -130,7 +129,6 @@ int is_passwd_env_enable(void)
>  
>  	return 1;
>  }
> -EXPORT_SYMBOL(is_passwd_env_enable);
>  
>  int passwd_env_disable(void)
>  {
> @@ -227,7 +225,7 @@ exit:
>  }
>  EXPORT_SYMBOL(read_env_passwd);
>  
> -int write_env_passwd(unsigned char *sum, size_t length)
> +static int write_env_passwd(unsigned char *sum, size_t length)
>  {
>  	int fd;
>  	unsigned char c;
> @@ -274,7 +272,6 @@ exit:
>  
>  	return ret;
>  }
> -EXPORT_SYMBOL(write_env_passwd);
>  
>  static int check_passwd(unsigned char *passwd, size_t length)
>  {
> -- 
> 2.6.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


-- 
-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-11-01  5:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30 12:55 Sergey Koshechkin
2015-11-01  6:12 ` Antony Pavlov [this message]
2015-11-02  7:06   ` Sascha Hauer
2015-11-02  6:59 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151101091258.42b5fa76f90ea1e9dee76ffe@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=tritel59@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox