mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org, jbe@pengutronix.de
Subject: Re: [PATCH] ata: disk_ata_drive: remove obsolete check for ID validity
Date: Mon, 2 Nov 2015 07:58:14 +0100	[thread overview]
Message-ID: <20151102065814.GC25308@pengutronix.de> (raw)
In-Reply-To: <1446199245-15646-1-git-send-email-pmamonov@gmail.com>

On Fri, Oct 30, 2015 at 01:00:45PM +0300, Peter Mamonov wrote:
> Acked-by: Juergen Borleis <jbe@pengutronix.de>
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> ---
>  drivers/ata/disk_ata_drive.c | 17 -----------------
>  1 file changed, 17 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/ata/disk_ata_drive.c b/drivers/ata/disk_ata_drive.c
> index ee1709e..d30d0ad 100644
> --- a/drivers/ata/disk_ata_drive.c
> +++ b/drivers/ata/disk_ata_drive.c
> @@ -26,16 +26,6 @@
>  #include <disks.h>
>  #include <dma.h>
>  
> -static int ata_id_is_valid(const uint16_t *id)
> -{
> -	if ((id[ATA_ID_FIELD_VALID] & 1) == 0) {
> -		pr_debug("Drive's ID seems invalid\n");
> -		return -EINVAL;
> -	}
> -
> -	return 0;
> -}
> -
>  static uint64_t ata_id_n_sectors(uint16_t *id)
>  {
>  	if (ata_id_has_lba(id)) {
> @@ -244,13 +234,6 @@ static int ata_port_init(struct ata_port *port)
>  
>  	ata_fix_endianess(port->id, SECTOR_SIZE / sizeof(uint16_t));
>  
> -	rc = ata_id_is_valid(port->id);
> -	if (rc) {
> -		dev_err(dev, "ata id invalid\n");
> -		free(port->id);
> -		return rc;
> -	}
> -
>  #ifdef DEBUG
>  	ata_dump_id(port->id);
>  #endif
> -- 
> 2.1.4
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-11-02  6:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30 10:00 Peter Mamonov
2015-11-02  6:58 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151102065814.GC25308@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=jbe@pengutronix.de \
    --cc=pmamonov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox