From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fs: smhfs: Fix return value of truncate()
Date: Mon, 9 Nov 2015 07:18:08 +0100 [thread overview]
Message-ID: <20151109061808.GN8526@pengutronix.de> (raw)
In-Reply-To: <1447028473-20462-1-git-send-email-andrew.smirnov@gmail.com>
On Sun, Nov 08, 2015 at 04:21:13PM -0800, Andrey Smirnov wrote:
> Returning -ENOSYS as a result of truncate() breaks ability to write to
> semihosting host's filesystem, so change the return value to 0. This
> shouldn't cause any problems since all of the funcionlaity of
> truncate() should is already handled by 'open' (via O_TRUNC) and
> 'write' (will automatically grow the file size when writing)
> automatically
>
> Unfortunately this was missed in original commit that introduced
> semihosting
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Applied, thanks
Sascha
> ---
> fs/smhfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smhfs.c b/fs/smhfs.c
> index a0df06c..f1b6d6b 100644
> --- a/fs/smhfs.c
> +++ b/fs/smhfs.c
> @@ -58,7 +58,7 @@ static int smhfs_truncate(struct device_d __always_unused *dev,
> FILE __always_unused *f,
> ulong __always_unused size)
> {
> - return -ENOSYS;
> + return 0;
> }
>
> static int smhfs_open(struct device_d __always_unused *dev,
> --
> 2.1.4
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-11-09 6:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 0:21 Andrey Smirnov
2015-11-09 6:18 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109061808.GN8526@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox