From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jason Cobham <cobham.jason@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: i.mx53: Add support for Digi ConnectCore ccwmx53 SOM
Date: Tue, 10 Nov 2015 08:53:08 +0100 [thread overview]
Message-ID: <20151110075308.GI4931@pengutronix.de> (raw)
In-Reply-To: <CAKu_b=K0JvT5g-Zzvs1nRBHjBK2ssWou3ZNhMuviZOZ4dt2W=w@mail.gmail.com>
Hello Jason,
there are several problems with this patch:
- No Signed-off-by line
- A i.MX machine should really use dt
- The patch is line-wrapped which makes impossible to apply without
handwork (unless git has improved accordingly since I looked at such
a patch last time)
- Use tabs for indention
- There is no need for a ccwmx53.h if there is only a single #includer
- I don't know how you created the patch, but it wasn't git
format-patch which I'd recommend here
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-11-10 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 4:17 Jason Cobham
2015-11-10 7:53 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151110075308.GI4931@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=cobham.jason@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox