From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] common: filetype: do not redetect MBR-type devices as a FAT-type
Date: Wed, 11 Nov 2015 08:35:22 +0100 [thread overview]
Message-ID: <20151111073522.GJ8526@pengutronix.de> (raw)
In-Reply-To: <1447065171-31571-1-git-send-email-pmamonov@gmail.com>
On Mon, Nov 09, 2015 at 01:32:51PM +0300, Peter Mamonov wrote:
> Deleted pieces of code detect MBR-containig device as a FAT-type device,
> if it's first partition contains a FAT filesystem. This behaviour enabled one
> to mount the FAT FS which is either directly on the device (disk0) or on
> the first partition (disk0.0) using the same command:
> mount /dev/disk0 /fat
> However, the desired behaviour can be reached with a:
> mount /dev/disk0 /fat || mount /dev/disk0.0 /fat || echo "Mounting failed"
>
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Please don't add Acked-by for patches the person has never seen. I
agreed to the approach of removing the check here, but I can only ever
ack a patch that I have seen.
Applied this with my ack removed.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-11-11 7:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 10:32 Peter Mamonov
2015-11-09 11:18 ` Antony Pavlov
2015-11-09 18:49 ` Trent Piepho
2015-11-10 8:04 ` Sascha Hauer
2015-11-10 8:15 ` Sascha Hauer
2015-11-10 18:44 ` Trent Piepho
2015-11-11 7:35 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111073522.GJ8526@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox