From: Antony Pavlov <antonynpavlov@gmail.com>
To: Du Huanpeng <u74147@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] lib: readline support ctrl-l to clear screen
Date: Sun, 15 Nov 2015 11:50:49 +0300 [thread overview]
Message-ID: <20151115115049.ce397ba71f0d859b5363dbce@gmail.com> (raw)
In-Reply-To: <1447549279-11694-1-git-send-email-u74147@gmail.com>
On Sun, 15 Nov 2015 09:01:19 +0800
Du Huanpeng <u74147@gmail.com> wrote:
You have submited at lease two patches with '[PATCH] lib: readline support ctrl-l to clear screen' subject.
The patches differ from each other. This causes causes a great deal of confusion.
Please add a version tag when resending patches, see this for details:
http://wiki.qemu.org/Contribute/SubmitAPatch#When_resending_patches_add_a_version_tag
> maybe it is easier to press ctrl-l to clear the screen than type
> 'clear' command.
>
> Signed-off-by: Du Huanpeng <u74147@gmail.com>
> ---
> lib/readline.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/lib/readline.c b/lib/readline.c
> index 14dd311..170effb 100644
> --- a/lib/readline.c
> +++ b/lib/readline.c
> @@ -262,6 +262,15 @@ int readline(const char *prompt, char *buf, int len)
> eol_num--;
> }
> break;
> + case CTL_CH('l'):
> + printf(ANSI_CLEAR_SCREEN);
> + buf[eol_num] = 0;
> + printf("%s%s", prompt, buf);
> + wlen = eol_num - num;
> + while (wlen--) {
> + getcmd_putch(CTL_BACKSPACE);
> + }
> + break;
> case BB_KEY_ERASE_TO_EOL:
> ERASE_TO_EOL();
> break;
> --
> 1.9.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-11-15 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 1:01 Du Huanpeng
2015-11-15 8:50 ` Antony Pavlov [this message]
2015-11-17 8:15 ` Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2015-11-14 11:29 Du Huanpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151115115049.ce397ba71f0d859b5363dbce@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=u74147@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox