From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sergey Koshechkin <serge.koshechkin@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] crypto: crc32: fix warnings: no previous prototype for 'crc32', 'crc32_no_comp', 'file_crc'
Date: Wed, 18 Nov 2015 08:30:32 +0100 [thread overview]
Message-ID: <20151118073032.GS8526@pengutronix.de> (raw)
In-Reply-To: <1447762452-13433-1-git-send-email-serge.koshechkin@gmail.com>
On Tue, Nov 17, 2015 at 03:14:12PM +0300, Sergey Koshechkin wrote:
> Signed-off-by: Sergey Koshechkin <serge.koshechkin@gmail.com>
> ---
> crypto/crc32.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/crypto/crc32.c b/crypto/crc32.c
Applied, thanks.
Sascha
> index e7b1bd7..58637bd 100644
> --- a/crypto/crc32.c
> +++ b/crypto/crc32.c
> @@ -16,6 +16,9 @@
> #include <malloc.h>
> #include <linux/ctype.h>
> #include <errno.h>
> +#define STATIC
> +#else
> +#define STATIC static inline
> #endif
>
> #ifdef CONFIG_DYNAMIC_CRC_TABLE
> @@ -138,7 +141,7 @@ static const ulong crc_table[256] = {
> #define DO8(buf) DO4(buf); DO4(buf);
>
> /* ========================================================================= */
> -uint32_t crc32(uint32_t crc, const void *_buf, unsigned int len)
> +STATIC uint32_t crc32(uint32_t crc, const void *_buf, unsigned int len)
> {
> const unsigned char *buf = _buf;
>
> @@ -164,7 +167,7 @@ EXPORT_SYMBOL(crc32);
> /* No ones complement version. JFFS2 (and other things ?)
> * don't use ones compliment in their CRC calculations.
> */
> -uint32_t crc32_no_comp(uint32_t crc, const void *_buf, unsigned int len)
> +STATIC uint32_t crc32_no_comp(uint32_t crc, const void *_buf, unsigned int len)
> {
> const unsigned char *buf = _buf;
>
> @@ -184,7 +187,7 @@ uint32_t crc32_no_comp(uint32_t crc, const void *_buf, unsigned int len)
> return crc;
> }
>
> -int file_crc(char *filename, ulong start, ulong size, ulong *crc,
> +STATIC int file_crc(char *filename, ulong start, ulong size, ulong *crc,
> ulong *total)
> {
> int fd, now;
> --
> 2.6.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-11-18 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 12:14 Sergey Koshechkin
2015-11-18 7:30 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118073032.GS8526@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=serge.koshechkin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox