From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZyxRD-00022R-3T for barebox@lists.infradead.org; Wed, 18 Nov 2015 07:45:55 +0000 Date: Wed, 18 Nov 2015 08:45:32 +0100 From: Sascha Hauer Message-ID: <20151118074532.GU8526@pengutronix.de> References: <1447762522-13533-1-git-send-email-serge.koshechkin@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1447762522-13533-1-git-send-email-serge.koshechkin@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/3] Makefile: set -Wmissing-prototypes on all architechtures (was only on mips) To: Sergey Koshechkin Cc: barebox@lists.infradead.org On Tue, Nov 17, 2015 at 03:15:22PM +0300, Sergey Koshechkin wrote: > Signed-off-by: Sergey Koshechkin > --- > Makefile | 2 +- > arch/mips/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 1029dc1..9a54a44 100644 > --- a/Makefile > +++ b/Makefile > @@ -183,7 +183,7 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \ > > HOSTCC = gcc > HOSTCXX = g++ > -HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer > +HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer > HOSTCXXFLAGS = -O2 > > # Decide whether to build built-in, modular, or both. > diff --git a/arch/mips/Makefile b/arch/mips/Makefile > index 75761b5..b003945 100644 > --- a/arch/mips/Makefile > +++ b/arch/mips/Makefile > @@ -12,7 +12,7 @@ endif > CPPFLAGS += -D__MIPS__ -fno-strict-aliasing -fno-merge-constants > > cflags-y += -G 0 -mno-abicalls -fno-pic -pipe > -cflags-y += -Wall -Wmissing-prototypes -Wstrict-prototypes \ You are removing this from cflags, but adding to HOSTCFLAGS above, these variables are not equivalent. You should add to CFLAGS instead. Now I know why I haven't seen these warnings from the host tools before. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox