From: Stefan Christ <s.christ@phytec.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH v2 2/3] net: fec: implement dtb property phy-reset-duration
Date: Wed, 18 Nov 2015 10:15:24 +0100 [thread overview]
Message-ID: <20151118091524.GA2509@lws-christ> (raw)
In-Reply-To: <1447837725-21625-2-git-send-email-s.christ@phytec.de>
Hi,
ups. Change information is missing:
v2: Remove upper bound check of reset duration and update commit message
Mit freundlichen Grüßen / Kind regards,
Stefan Christ
On Wed, Nov 18, 2015 at 10:08:44AM +0100, Stefan Christ wrote:
> Implement device tree property phy-reset-duration to adjust length of
> phy reset.
>
> Signed-off-by: Stefan Christ <s.christ@phytec.de>
> ---
> drivers/net/fec_imx.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
> index f19d046..70087ad 100644
> --- a/drivers/net/fec_imx.c
> +++ b/drivers/net/fec_imx.c
> @@ -654,6 +654,7 @@ static int fec_probe(struct device_d *dev)
> int ret;
> enum fec_type type;
> int phy_reset;
> + u32 msec = 1;
>
> ret = dev_get_drvdata(dev, (const void **)&type);
> if (ret)
> @@ -684,6 +685,8 @@ static int fec_probe(struct device_d *dev)
>
> phy_reset = of_get_named_gpio(dev->device_node, "phy-reset-gpios", 0);
> if (gpio_is_valid(phy_reset)) {
> + of_property_read_u32(dev->device_node, "phy-reset-duration", &msec);
> +
> ret = gpio_request(phy_reset, "phy-reset");
> if (ret)
> goto err_free;
> @@ -692,7 +695,7 @@ static int fec_probe(struct device_d *dev)
> if (ret)
> goto err_free;
>
> - mdelay(1);
> + mdelay(msec);
> gpio_set_value(phy_reset, 1);
> }
>
> --
> 1.9.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-11-18 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 9:08 [PATCH v2 1/3] net: fec: set phy reset time to 1ms Stefan Christ
2015-11-18 9:08 ` [PATCH v2 2/3] net: fec: implement dtb property phy-reset-duration Stefan Christ
2015-11-18 9:15 ` Stefan Christ [this message]
2015-11-18 9:08 ` [PATCH v2 3/3] net: fec: fix indentation and whitspaces Stefan Christ
2015-11-19 7:33 ` [PATCH v2 1/3] net: fec: set phy reset time to 1ms Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118091524.GA2509@lws-christ \
--to=s.christ@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox