From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC 0/2] add multiplexed I2C bus support
Date: Thu, 19 Nov 2015 08:41:12 +0100 [thread overview]
Message-ID: <20151119074112.GA11966@pengutronix.de> (raw)
In-Reply-To: <1447851604-18072-1-git-send-email-antonynpavlov@gmail.com>
On Wed, Nov 18, 2015 at 04:00:02PM +0300, Antony Pavlov wrote:
> This patchseries adds multiplexed I2C bus support to barebox
> and a driver for pca954x bus multiplexer.
>
> This series has the "RFC" status mostly because of these
> adapter numbering hack in drivers/i2c/i2c-mux.c:
>
> /* FIXME */
> // priv->adap.nr = mux_dev->id;
> priv->adap.nr = -1;
> ret = i2c_add_numbered_adapter(&priv->adap);
What's wrong with -1 as adapter nr? Why do consider this a hack?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-11-19 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 13:00 Antony Pavlov
2015-11-18 13:00 ` [RFC 1/2] i2c: import multiplexed I2C bus core support from linux kernel Antony Pavlov
2015-11-18 13:00 ` [RFC 2/2] i2c: add pca954x bus multiplexer driver Antony Pavlov
2015-11-19 7:41 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119074112.GA11966@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox