mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jan Remmet <j.remmet@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] state: make type check error verbose
Date: Mon, 23 Nov 2015 07:52:48 +0100	[thread overview]
Message-ID: <20151123065248.GN11966@pengutronix.de> (raw)
In-Reply-To: <1448010198-23247-1-git-send-email-j.remmet@phytec.de>

On Fri, Nov 20, 2015 at 10:03:18AM +0100, Jan Remmet wrote:
> Wrong type let state probe fail with ENOENT.
> 
> Signed-off-by: Jan Remmet <j.remmet@phytec.de>
> ---
>  common/state.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/common/state.c b/common/state.c
> index 117a686..a161b94 100644
> --- a/common/state.c
> +++ b/common/state.c
> @@ -716,6 +716,8 @@ static int state_convert_node_variable(struct state *state,
>  
>  	vtype = state_find_type_by_name(type_name);
>  	if (!vtype) {
> +		dev_err(&state->dev, "unkown type: %s in %s\n", type_name,
> +			node->full_name);
>  		ret = -ENOENT;
>  		goto out_free;
>  	}
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-11-23  6:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20  9:03 Jan Remmet
2015-11-23  6:52 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151123065248.GN11966@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=j.remmet@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox