From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: usb: asix: make rx_fixup ax_skb buffer aligned
Date: Mon, 23 Nov 2015 08:37:10 +0100 [thread overview]
Message-ID: <20151123073710.GU11966@pengutronix.de> (raw)
In-Reply-To: <1448221767-14769-1-git-send-email-antonynpavlov@gmail.com>
On Sun, Nov 22, 2015 at 10:49:27PM +0300, Antony Pavlov wrote:
> ax_skb receive buffer unalignment leads to consequent
> unalignment data access in network stack routines,
> especially in net_checksum().
>
> By-turn unalignment data accesses lead to performance penalty.
> Moreover on classic MIPS CPUs without hardware unalignment access
> support this leads to undesirable exceptions.
>
> At the moment barebox on MIPS can't parry these unalignment access
> exceptions, so the Asix USB Ethernet chips, that need receive
> fixup workaround, are completely unusable on MIPS without this patch.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Applied, thanks
Sascha
> ---
> drivers/net/usb/asix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
> index 4c53a14..ff80398 100644
> --- a/drivers/net/usb/asix.c
> +++ b/drivers/net/usb/asix.c
> @@ -158,7 +158,7 @@ struct asix_rx_fixup_info {
> u16 size;
> u16 offset;
> bool split_head;
> - unsigned char ax_skb[RX_FIXUP_SIZE];
> + unsigned char ax_skb[RX_FIXUP_SIZE] __aligned(2);
> };
>
> struct asix_common_private {
> --
> 2.6.2
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-11-23 7:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 19:49 Antony Pavlov
2015-11-23 7:37 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123073710.GU11966@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox