mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [just RFC 0/2] serial: ns16550: add Ralink UART support
Date: Tue, 24 Nov 2015 09:14:23 +0100	[thread overview]
Message-ID: <20151124081423.GB11966@pengutronix.de> (raw)
In-Reply-To: <1448265336-15862-1-git-send-email-antonynpavlov@gmail.com>

Hi Antony,

On Mon, Nov 23, 2015 at 10:55:34AM +0300, Antony Pavlov wrote:
> Please dont apply this patchseries! It's for review only!
> 
> This patchseries adds support for ns16550-like UART
> used in Ralink/Mediatek SoCs. This UART uses non-standard
> register addresses.

I'm getting unsure how much sense it makes to expand the ns16550 driver
like this and like we've done with Omap, Tegra and others. It's always a
little weight that we add to the driver and maybe we have reached the
point where we should split the driver into several SoC specific drivers
and some common library helper code for the general ns16550 support.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2015-11-24  8:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23  7:55 Antony Pavlov
2015-11-23  7:55 ` [just RFC 1/2] serial: ns16550: introduce custom divisor latch setter Antony Pavlov
2015-11-23  7:55 ` [just RFC 2/2] serial: ns16550: add Ralink UART support Antony Pavlov
2015-11-24  8:14 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124081423.GB11966@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox