From: Sascha Hauer <s.hauer@pengutronix.de>
To: Trent Piepho <tpiepho@kymetacorp.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] ARM: Remove do_execute and thumb2_execute
Date: Mon, 7 Dec 2015 10:45:04 +0100 [thread overview]
Message-ID: <20151207094504.GD11966@pengutronix.de> (raw)
In-Reply-To: <1449257064.26955.20.camel@rtred1test09.kymeta.local>
On Fri, Dec 04, 2015 at 07:24:19PM +0000, Trent Piepho wrote:
> In commit 104a6a7ccfb7928ca5dc28c8cbe0ea231ffc45ee support was added
> for Thumb2. It added do_execute() as a way to provide arch dependent
> calling veneers for use in "go" and thumb2_execute() as the thumb2 to
> arm veneer.
>
> But thumb2_execute() isn't necessary as gcc generates a proper calling
> sequence from a standard function pointer call. Thumb2 barebox is
> compiled with the AAPCS ABI which requires this.
>
> It also had a bug and didn't pass the arguments properly, but code
> execute via "go" rarely uses arguments so this wasn't very noticeable.
>
> Since thumb2 was always the only user of do_execute(), go ahead and
> delete that too.
>
> Signed-off-by: Trent Piepho <tpiepho@kymetacorp.com>
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-12-07 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 19:24 Trent Piepho
2015-12-07 9:45 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207094504.GD11966@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=tpiepho@kymetacorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox