mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Trent Piepho <tpiepho@kymetacorp.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] partitions: UUID was missing from partitions by name
Date: Thu, 10 Dec 2015 09:00:29 +0100	[thread overview]
Message-ID: <20151210080029.GE11966@pengutronix.de> (raw)
In-Reply-To: <1449698135.26955.58.camel@rtred1test09.kymeta.local>

On Wed, Dec 09, 2015 at 09:55:29PM +0000, Trent Piepho wrote:
> The partition code registers one or two cdevs for each partition.  The
> 2nd one is used if the partition has a name.  The block of code for
> each cdev is duplicated twice, and the 2nd copy is missing the bit
> that copies the partition uuid and the dos partition type to the cdev.
> 
> Refactor the register cdev out to a new function that is called twice.
> This way each cdev is done correctly.

Nice. Besides of fixing a bug this makes intention of the code is much
clearer. Thanks, applied.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2015-12-10  8:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 21:55 Trent Piepho
2015-12-09 22:04 ` [PATCH 2/2] partitions/efi: Add partuuid to partition description Trent Piepho
2015-12-09 23:38   ` [PATCH 2/2 v2] " Trent Piepho
2015-12-10  8:00 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151210080029.GE11966@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=tpiepho@kymetacorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox