mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Trent Piepho <tpiepho@kymetacorp.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] bootstrap: Boot barebox with kernel calling convention
Date: Fri, 11 Dec 2015 08:25:15 +0100	[thread overview]
Message-ID: <20151211072515.GT11966@pengutronix.de> (raw)
In-Reply-To: <1449777657.26955.70.camel@rtred1test09.kymeta.local>

On Thu, Dec 10, 2015 at 08:00:50PM +0000, Trent Piepho wrote:
> In commit 8e3ddc13eb8239177ed20f119e3a3d02518b941d the bootm code was
> changed to boot barebox using the same calling convention as the
> kernel.  Which on ARM is to pass three arguments which are zero, an
> architecture code, and a params pointer.
> 
> A 2nd stage barebox can be booted using lib/bootstrap, which is
> different code from bootm.  This code just leaves garbage in the first
> three parameters and so doesn't follow the convention.
> 
> Change it to be compatible with the ARM kernel booting convention.
> This just sends a zero for the architecture, since the code for
> architectures depends on boot[zmu] and something using bootstrap
> wouldn't have those too.  And it just passes NULL for the params since
> we don't have a way to pass a device tree from the preloader.
> 
> All users of bootstrap are ARM based, but the code is in lib so a
> non-ARM board might someday make use of it.  If the current code would
> work for them, then the change here will be ok too.
> 
> Signed-off-by: Trent Piepho <tpiepho@kymetacorp.com>
> ---

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-12-11  7:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 20:00 Trent Piepho
2015-12-11  7:25 ` Sascha Hauer [this message]
2015-12-14 10:15 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151211072515.GT11966@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=tpiepho@kymetacorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox