From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a7I5B-0001Ze-OR for barebox@lists.infradead.org; Fri, 11 Dec 2015 07:25:38 +0000 Date: Fri, 11 Dec 2015 08:25:15 +0100 From: Sascha Hauer Message-ID: <20151211072515.GT11966@pengutronix.de> References: <1449777657.26955.70.camel@rtred1test09.kymeta.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1449777657.26955.70.camel@rtred1test09.kymeta.local> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] bootstrap: Boot barebox with kernel calling convention To: Trent Piepho Cc: barebox On Thu, Dec 10, 2015 at 08:00:50PM +0000, Trent Piepho wrote: > In commit 8e3ddc13eb8239177ed20f119e3a3d02518b941d the bootm code was > changed to boot barebox using the same calling convention as the > kernel. Which on ARM is to pass three arguments which are zero, an > architecture code, and a params pointer. > > A 2nd stage barebox can be booted using lib/bootstrap, which is > different code from bootm. This code just leaves garbage in the first > three parameters and so doesn't follow the convention. > > Change it to be compatible with the ARM kernel booting convention. > This just sends a zero for the architecture, since the code for > architectures depends on boot[zmu] and something using bootstrap > wouldn't have those too. And it just passes NULL for the params since > we don't have a way to pass a device tree from the preloader. > > All users of bootstrap are ARM based, but the code is in lib so a > non-ARM board might someday make use of it. If the current code would > work for them, then the change here will be ok too. > > Signed-off-by: Trent Piepho > --- Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox