mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Trent Piepho <tpiepho@kymetacorp.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH 4/4] socfpga: Find partition with environment via device tree
Date: Fri, 18 Dec 2015 08:32:22 +0100	[thread overview]
Message-ID: <20151218073222.GH11966@pengutronix.de> (raw)
In-Reply-To: <1450386805.26955.221.camel@rtred1test09.kymeta.local>

On Thu, Dec 17, 2015 at 09:13:25PM +0000, Trent Piepho wrote:
> On Thu, 2015-12-17 at 11:07 +0100, Sascha Hauer wrote:
> > >  / {
> > > +	chosen {
> > > +		environment@0 {
> > > +			compatible = "barebox,environment";
> > > +			device-path = &mmc, "partname:1";
> > > +			file-path = "barebox.env";
> > > +		};
> > > +	};
> > > +
> > 
> > I applied this series as is. We might have to move this to the board dts
> > files later as putting this into the SoC dtsi file does not allow the
> > boards to put the environment somewhere else. That was not possible
> > before this patch either, so this doesn't change much at the moment.
> 
> It's possible to change in the board dts by adding a
> "/chosen/environment@0" node to the dts with whatever properties should
> be overridden from the dtsi file's values.  Like how status = "disabled"
> in dtsi is changed to status = "okay" in the board file.  I do this for
> my board as "partname:1" isn't correct for me.

We might also have to delete the file-path property in a board dts. I
just learned that this indeed works with /delete-property/ in dtc, but I
am not sure if we should really use this, the deep levels of device tree
includes are already hard enough to track (Not necessarily for socfpga,
but have a look at some i.MX6 SoMs)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-12-18  7:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17  0:48 [PATCH 1/4] partitions/efi: Add partuuid to partition description Trent Piepho
2015-12-17  0:52 ` [PATCH 2/4] of_path: Fix bug with partitions, simply code Trent Piepho
2015-12-17  0:52 ` [PATCH 3/4] environment: Support env from file in a file-system via device tree Trent Piepho
2015-12-17  0:53 ` [PATCH 4/4] socfpga: Find partition with environment " Trent Piepho
2015-12-17 10:07   ` Sascha Hauer
2015-12-17 21:13     ` Trent Piepho
2015-12-18  7:32       ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151218073222.GH11966@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=tpiepho@kymetacorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox