From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Tim Sander <tim@krieglstein.org>
Subject: Re: [PATCH v4] Terasic DE0-Nano-SoC: add support
Date: Tue, 2 Feb 2016 09:03:58 +0100 [thread overview]
Message-ID: <20160202080358.GE4118@pengutronix.de> (raw)
In-Reply-To: <CAHQ1cqEBXBziKFGPaDQBK3zMw0+D4cnjvB2KXHBF906UG8Ahwg@mail.gmail.com>
On Mon, Feb 01, 2016 at 11:08:10AM -0800, Andrey Smirnov wrote:
> On Mon, Feb 1, 2016 at 8:09 AM, Tim Sander <tim@krieglstein.org> wrote:
> > v4: use the amended patch not the old one, doh. Sorry for the noise.
> >
> > +static inline void ledon(int led)
> > +{
> > + u32 val;
> > +
> > + val = readl(0xFF709000);
> > + val |= 1 << (led + 24);
> > + writel(val, 0xFF709000);
> > +
> > + val = readl(0xFF709004);
> > + val |= 1 << (led + 24);
> > + writel(val, 0xFF709004);
> > +}
> > +
> > +static inline void ledoff(int led)
> > +{
> > + u32 val;
> > +
> > + val = readl(0xFF709000);
> > + val &= ~(1 << (led + 24));
> > + writel(val, 0xFF709000);
> > +
> > + val = readl(0xFF709004);
> > + val &= ~(1 << (led + 24));
> > + writel(val, 0xFF709004);
> > +}
>
> Where are those "ledoff" and "ledon" functions used?
I assume they are for early debugging and otherwise unused. It's ok to
leave them here. Maybe add a comment why they are here, also some
indication for valid led values would be nice.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-02-02 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 16:09 Tim Sander
2016-02-01 19:08 ` Andrey Smirnov
2016-02-02 8:03 ` Sascha Hauer [this message]
2016-02-02 23:30 ` Trent Piepho
2016-02-03 1:16 ` Andrey Smirnov
2016-02-11 14:40 ` Tim Sander
2016-02-12 8:33 ` Sascha Hauer
2016-02-12 13:13 ` Tim Sander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202080358.GE4118@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.trumtrar@pengutronix.de \
--cc=tim@krieglstein.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox