From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aREdt-0008MI-92 for barebox@lists.infradead.org; Thu, 04 Feb 2016 07:47:54 +0000 Date: Thu, 4 Feb 2016 08:47:31 +0100 From: Sascha Hauer Message-ID: <20160204074731.GR4118@pengutronix.de> References: <1454296213-12734-1-git-send-email-andrew.smirnov@gmail.com> <1454296213-12734-8-git-send-email-andrew.smirnov@gmail.com> <20160203073619.GH4118@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 7/8] mdio_bus: Change PHY's naming scheme To: Andrey Smirnov Cc: "barebox@lists.infradead.org" Hi Andrey, On Wed, Feb 03, 2016 at 11:23:38AM -0800, Andrey Smirnov wrote: > On Tue, Feb 2, 2016 at 11:36 PM, Sascha Hauer wrote: > > On Sun, Jan 31, 2016 at 07:10:12PM -0800, Andrey Smirnov wrote: > >> Change the way PHY devices are named upon creation. This commit replaces > >> sequentialy numbered "/dev/phy%d" with "/dev/mdio%d-phy%02x". This way > >> it is significanlty easier to identify which PHY in real-life (e.g. on a > >> schematic) corresponds to which device in /dev. > >> > >> Also, replace asprintf with xasprintf to provide some form of memory > >> allocation failure checking. > >> > >> Signed-off-by: Andrey Smirnov > >> --- > >> drivers/net/phy/mdio_bus.c | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c > >> index b74b27e..41bf018 100644 > >> --- a/drivers/net/phy/mdio_bus.c > >> +++ b/drivers/net/phy/mdio_bus.c > >> @@ -333,7 +333,9 @@ static int mdio_bus_probe(struct device_d *_dev) > >> dev_add_param_int_ro(&dev->dev, "phy_addr", dev->addr, "%d"); > >> dev_add_param_int_ro(&dev->dev, "phy_id", dev->phy_id, "0x%08x"); > >> > >> - dev->cdev.name = asprintf("phy%d", _dev->id); > >> + dev->cdev.name = xasprintf("mdio%d-phy%02x", > >> + dev->bus->dev.id, > >> + dev->addr); > > > > While at it we can change the phy device name in the same way to be > > consistent: > > Yeah, I agree, let's do this. Let me know if I should do v3 patch set. I'll squash that here as necessary. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox