mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] ramoops: allow to build without OFTREE support
@ 2016-02-11  9:33 Lucas Stach
  2016-02-11  9:33 ` [PATCH 2/2] ratp-console: select CRC16 and POLLER, depend on CONSOLE_FULL Lucas Stach
  2016-02-11 12:56 ` [PATCH 1/2] ramoops: allow to build without OFTREE support Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Lucas Stach @ 2016-02-11  9:33 UTC (permalink / raw)
  To: barebox

Ramoops may be useful even without oftree support, as kernels
booted without a DT may have other means to reserve the
ramoops memory.

Fixes:
In function `ramoops_probe':
undefined reference to `of_add_reserve_entry'

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 fs/pstore/ram.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 66b4975a3035..fdd92a60a57a 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -455,7 +455,8 @@ static int ramoops_probe(struct ramoops_platform_data *pdata)
 		  ramoops_ecc);
 	globalvar_add_simple("linux.bootargs.ramoops", kernelargs);
 
-	of_add_reserve_entry(cxt->phys_addr, cxt->phys_addr + mem_size);
+	if (IS_ENABLED(CONFIG_OFTREE))
+		of_add_reserve_entry(cxt->phys_addr, cxt->phys_addr + mem_size);
 
 	return 0;
 
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ratp-console: select CRC16 and POLLER, depend on CONSOLE_FULL
  2016-02-11  9:33 [PATCH 1/2] ramoops: allow to build without OFTREE support Lucas Stach
@ 2016-02-11  9:33 ` Lucas Stach
  2016-02-11 12:56 ` [PATCH 1/2] ramoops: allow to build without OFTREE support Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Lucas Stach @ 2016-02-11  9:33 UTC (permalink / raw)
  To: barebox

RATP console selects RATP, which in turn selects CRC16, but those
chains don't work in Kconfig, so select CRC16 also from the
console option.

Also fix build errors by depending on CONSOLE_FULL and selecting
POLLER.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 common/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/Kconfig b/common/Kconfig
index fc3ed8e57d73..3b87a3c8f8d2 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -623,6 +623,9 @@ config PBL_CONSOLE
 config CONSOLE_RATP
 	bool
 	select RATP
+	select CRC16
+	select POLLER
+	depends on CONSOLE_FULL
 	prompt "RATP console support"
 	help
 	  This option adds support for remote controlling barebox via serial
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ramoops: allow to build without OFTREE support
  2016-02-11  9:33 [PATCH 1/2] ramoops: allow to build without OFTREE support Lucas Stach
  2016-02-11  9:33 ` [PATCH 2/2] ratp-console: select CRC16 and POLLER, depend on CONSOLE_FULL Lucas Stach
@ 2016-02-11 12:56 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2016-02-11 12:56 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Thu, Feb 11, 2016 at 10:33:55AM +0100, Lucas Stach wrote:
> Ramoops may be useful even without oftree support, as kernels
> booted without a DT may have other means to reserve the
> ramoops memory.
> 
> Fixes:
> In function `ramoops_probe':
> undefined reference to `of_add_reserve_entry'
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  fs/pstore/ram.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-11 12:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-11  9:33 [PATCH 1/2] ramoops: allow to build without OFTREE support Lucas Stach
2016-02-11  9:33 ` [PATCH 2/2] ratp-console: select CRC16 and POLLER, depend on CONSOLE_FULL Lucas Stach
2016-02-11 12:56 ` [PATCH 1/2] ramoops: allow to build without OFTREE support Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox