From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/3] Fix return check of dev_request_mem_region
Date: Tue, 23 Feb 2016 08:15:06 +0100 [thread overview]
Message-ID: <20160223071506.GT3939@pengutronix.de> (raw)
In-Reply-To: <CAHQ1cqGi2M1hKD0sMMWp=NRGyOmgtDvTOopE41UzUurErhXwyw@mail.gmail.com>
On Fri, Feb 19, 2016 at 11:12:24AM -0800, Andrey Smirnov wrote:
> >>
> >> // Fix the check itself. Having this as a standalone rule allows
> >> // to catch cases where error codepath doesn't bail out
> >> @depends on i@
> >
> > I assume you mean "depends on rule1", because otherwise it never
> > actually changes the wrong error check.
> >
>
> Darn! I missed that regression. The problem with making it depending
> on "rule1" is that it misses the cases where only the incorrect check
> is performed and no bailing out is done (atmel_nand.c).
>
>
> > Overall this looks better than my version. I recreated the patch with
> > your version and fixed up the altera-tse driver manually.
>
> In case you missed it there's also "dove.c" that needs to be corrected manually.
Yes, I missed it. Fixed up manuelly now.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-02-23 7:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 10:50 [PATCH] dev_request_mem_region -> dev_request_mem_resource conversion Sascha Hauer
2016-02-18 10:50 ` [PATCH 1/3] Fix return check of dev_request_mem_region Sascha Hauer
2016-02-19 0:58 ` Andrey Smirnov
2016-02-19 8:29 ` Sascha Hauer
2016-02-19 19:12 ` Andrey Smirnov
2016-02-23 7:15 ` Sascha Hauer [this message]
2016-02-18 10:50 ` [PATCH 2/3] driver: Introduce dev_request_mem_resource Sascha Hauer
2016-02-18 10:50 ` [PATCH 3/3] driver: replace dev_request_mem_region with dev_request_mem_resource Sascha Hauer
2016-02-26 8:37 ` Teresa Remmet
2016-02-29 6:41 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223071506.GT3939@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox