From: Antony Pavlov <antonynpavlov@gmail.com>
To: yegorslists@googlemail.com
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 3/3] fs: add support for SquashFS 4.0
Date: Wed, 24 Feb 2016 01:34:48 +0300 [thread overview]
Message-ID: <20160224013448.d5d2d0a95dbcf164f1a6ee20@gmail.com> (raw)
In-Reply-To: <1455893355-17319-3-git-send-email-yegorslists@googlemail.com>
On Fri, 19 Feb 2016 15:49:15 +0100
yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> The driver was imported from Linux 4.4.
>
> Current implementation supports only XZ decompressor.
>
> Cc: Antony Pavlov <antonynpavlov@gmail.com>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
I have just tested this series on AR9331-based board, so
Tested-by: Antony Pavlov <antonynpavlov@gmail.com>
However there are some issues, see below
> --- /dev/null
> +++ b/Documentation/filesystems/squashfs.rst
> @@ -0,0 +1,15 @@
> +.. index:: squashfs (filesystem)
> +
> +SquashFS filesystem
> +===================
> +
> +SquashFS is a highly compressed read-only filesystem for Linux.
> +It uses zlib, lzo or xz compression to compress both files, inodes
> +and directories. A SquashFS filesystem can be mounted using the
> +:ref:`command_mount` command::
> +
> + mkdir /mnt
> + mount -t squashfs /dev/spiflash.FileSystem /mnt
> + ls /mnt
> + zImage barebox.bin
> + umount /mnt
Please add barebox prompt to this example, e.g.:
barebox:/ mkdir /mnt
barebox:/ mount -t squashfs /dev/spiflash.FileSystem /mnt
barebox:/ ls /mnt
zImage barebox.bin
barebox:/ umount /mnt
I suppose that the 'squashfs squashfs0: squashfs_mount' message is redundant, e.g:
barebox:/ mount -t squashfs /dev/spiflash.linux /mnt/
squashfs squashfs0: squashfs_mount
barebox:/ ls /mnt/
bin boot dev etc home init
lib lib32 linuxrc media mnt opt
proc root run sbin sys tmp
usr var
Also I see a memory leak on mount (By mistake I have tried to mount non-cdev squashfs image):
barebox:/ meminfo
used: 2693564
free: 14074728
barebox:/ mount -t squashfs rootfs.20160223.xz-squashfs /mnt/
squashfs squashfs0: probe failed: Invalid argument
mount: Invalid argument
barebox:/ meminfo
used: 2693636
free: 14074644
barebox:/ mount -t squashfs rootfs.20160223.xz-squashfs /mnt/
squashfs squashfs0: probe failed: Invalid argument
mount: Invalid argument
barebox:/ meminfo
used: 2693748
free: 14074524
barebox:/ mount -t squashfs rootfs.20160223.xz-squashfs /mnt/
squashfs squashfs0: probe failed: Invalid argument
mount: Invalid argument
barebox:/ meminfo
used: 2693832
free: 14074428
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-02-23 22:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 14:49 [PATCH v3 1/3] linux/types.h: add sector_t and blkcnt_t types yegorslists
2016-02-19 14:49 ` [PATCH v3 2/3] linux/fs.h: add types and routines needed for SquashFS yegorslists
2016-02-19 14:49 ` [PATCH v3 3/3] fs: add support for SquashFS 4.0 yegorslists
2016-02-23 22:34 ` Antony Pavlov [this message]
2016-02-25 9:38 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224013448.d5d2d0a95dbcf164f1a6ee20@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox