mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Kurz <akurz@blala.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] EP93xx eth: allow passing of phy config via platform data
Date: Wed, 24 Feb 2016 09:04:28 +0100	[thread overview]
Message-ID: <20160224080428.GD4207@pengutronix.de> (raw)
In-Reply-To: <1456077990-15003-1-git-send-email-akurz@blala.de>

Hi Alexander,

On Sun, Feb 21, 2016 at 07:06:28PM +0100, Alexander Kurz wrote:
> Passing phy configuration to the ep93xx_eth driver was not supported yet
> and will be added with this patch. When no pdata is passed, the probably
> broken default of phy_addr = 0 will be used to maintain compatibility
> with the previous implementation.
> 
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---
>  drivers/net/ep93xx.c | 14 ++++++++++++--
>  drivers/net/ep93xx.h |  2 ++
>  2 files changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ep93xx.c b/drivers/net/ep93xx.c
> index 90c12fc..d2458eb 100644
> --- a/drivers/net/ep93xx.c
> +++ b/drivers/net/ep93xx.c
> @@ -38,6 +38,7 @@
>  #include <linux/types.h>
>  #include <mach/ep93xx-regs.h>
>  #include <linux/phy.h>
> +#include <ep93xx_eth.h>

This file is missing. Forgot to git add it?
While at it, could you move it to include/net/ please?

Thanks
 Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2016-02-24  8:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21 18:06 Alexander Kurz
2016-02-21 18:06 ` [PATCH 2/3] edb9302 eth: privide proper phy config Alexander Kurz
2016-02-21 18:06 ` [PATCH 3/3] net ep93xx mii: do not supress MII preamble transmission Alexander Kurz
2016-02-23  8:03 ` [PATCH 1/3] EP93xx eth: allow passing of phy config via platform data Sascha Hauer
2016-02-24  8:04 ` Sascha Hauer [this message]
2016-02-24 20:07   ` Alexander Kurz
2016-02-25  8:43     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160224080428.GD4207@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=akurz@blala.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox