From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] bootm: fix uImage crashes when no partition is given
Date: Tue, 1 Mar 2016 08:23:57 +0100 [thread overview]
Message-ID: <20160301072357.GH9224@pengutronix.de> (raw)
In-Reply-To: <1456736735.3772.0.camel@pengutronix.de>
On Mon, Feb 29, 2016 at 10:05:35AM +0100, Lucas Stach wrote:
> Am Montag, den 29.02.2016, 08:48 +0100 schrieb Sascha Hauer:
> > On Fri, Feb 26, 2016 at 08:12:37PM +0100, Lucas Stach wrote:
> > > From: Lucas Stach <l.stach@pengutronix.de>
> > >
> > > Before the conversion to use the partition string instead of a plain
> > > integer the default was partition 0, now it's just a NULL pointer.
> > >
> > > There are a lot of places where strtoul is called on the partition string
> > > which crashes when encountering the NULL pointer. Instead of fixing all
> > > those places, plug in a default partition string that matches the old
> > > behavior by picking partition 0.
> >
> > This was my first approach aswell, but I didn't like the static "0"
> > string, so I came up with
> > http://lists.infradead.org/pipermail/barebox/2016-February/026368.html
> >
> Fix looks good.
>
> Can you drop this one patch, but apply the other 2 from this series?
Just did that. I just wanted to give it a few tests before doing it.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-03-01 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 19:12 Lucas Stach
2016-02-26 19:12 ` [PATCH 2/3] arm: bootm: unify kernel load address calculation Lucas Stach
2016-02-26 19:12 ` [PATCH 3/3] arm: bootm: be more clever about kernel spacing Lucas Stach
2016-02-29 7:48 ` [PATCH 1/3] bootm: fix uImage crashes when no partition is given Sascha Hauer
2016-02-29 9:05 ` Lucas Stach
2016-03-01 7:23 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301072357.GH9224@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox