From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] efi: fix memory leak in error path
Date: Fri, 4 Mar 2016 07:55:37 +0100 [thread overview]
Message-ID: <20160304065537.GA21869@pengutronix.de> (raw)
In-Reply-To: <1456951837-20843-1-git-send-email-dev@lynxeye.de>
On Wed, Mar 02, 2016 at 09:50:33PM +0100, Lucas Stach wrote:
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> arch/efi/efi/efi-device.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied all to master, thanks
Sascha
>
> diff --git a/arch/efi/efi/efi-device.c b/arch/efi/efi/efi-device.c
> index 7db8e48..678a283 100644
> --- a/arch/efi/efi/efi-device.c
> +++ b/arch/efi/efi/efi-device.c
> @@ -168,8 +168,10 @@ static struct efi_device *efi_add_device(efi_handle_t *handle, efi_guid_t **guid
>
> efiret = BS->open_protocol(handle, &efi_device_path_protocol_guid,
> &devpath, NULL, NULL, EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> - if (EFI_ERROR(efiret))
> + if (EFI_ERROR(efiret)) {
> + free(guidarr);
> return ERR_PTR(-EINVAL);
> + }
>
> efidev = xzalloc(sizeof(*efidev));
>
> --
> 2.5.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-03-04 6:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 20:50 Lucas Stach
2016-03-02 20:50 ` [PATCH 2/5] net: efi: correct function signature of set_ethaddr Lucas Stach
2016-03-02 20:50 ` [PATCH 3/5] fs: efi: avoid comparison with uninitialized variable Lucas Stach
2016-03-02 20:50 ` [PATCH 4/5] bbu: use correct printf format specifier for size_t Lucas Stach
2016-03-02 20:50 ` [PATCH 5/5] ratp: use proper defines for BAREBOX_CMD Lucas Stach
2016-03-04 6:55 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304065537.GA21869@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dev@lynxeye.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox