From: Sascha Hauer <s.hauer@pengutronix.de>
To: Aleksey Kuleshov <rndfax@yandex.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ehci-hcd: remove useless timeout
Date: Fri, 4 Mar 2016 08:11:52 +0100 [thread overview]
Message-ID: <20160304071152.GC21869@pengutronix.de> (raw)
In-Reply-To: <1457009332-27205-1-git-send-email-rndfax@yandex.ru>
Hi Aleksey,
On Thu, Mar 03, 2016 at 03:48:52PM +0300, Aleksey Kuleshov wrote:
> ---
> drivers/usb/host/ehci-hcd.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 862444b..9327015 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -1189,7 +1189,6 @@ static int ehci_destroy_int_queue(struct usb_device *dev,
> struct usb_host *host = dev->host;
> struct ehci_priv *ehci = to_ehci(host);
> struct QH *cur = ehci->periodic_queue;
> - uint64_t start;
>
> if (disable_periodic(ehci) < 0) {
> dev_err(&dev->dev,
> @@ -1198,7 +1197,6 @@ static int ehci_destroy_int_queue(struct usb_device *dev,
> }
> ehci->periodic_schedules--;
>
> - start = get_time_ns();
> while (!(cur->qh_link & cpu_to_hc32(QH_LINK_TERMINATE))) {
> dev_dbg(&dev->dev,
> "considering %p, with qh_link %x\n",
> @@ -1211,12 +1209,6 @@ static int ehci_destroy_int_queue(struct usb_device *dev,
> break;
> }
> cur = NEXT_QH(cur);
> - if (is_timeout_non_interruptible(start, 500 * MSECOND)) {
> - dev_err(&dev->dev,
> - "Timeout destroying interrupt endpoint queue\n");
> - result = -ETIMEDOUT;
> - goto out;
> - }
My first reaction was to ask you why you think that this timeout is
useless. Looking close at it I see that this is no register polling loop
but an iteration loop. Could you add a explanation to the commit log?
Also, like you other patches this one lacks a SoB. Please commit with
git commit -s.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-03-04 7:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 12:48 Aleksey Kuleshov
2016-03-04 7:11 ` Sascha Hauer [this message]
2016-03-04 10:42 ` Aleksey Kuleshov
2016-03-04 11:59 ` Antony Pavlov
2016-03-04 12:04 ` Aleksey Kuleshov
2016-03-04 13:59 ` Antony Pavlov
2016-03-04 15:03 ` Aleksey Kuleshov
2016-03-04 17:58 ` Andrey Smirnov
2016-03-04 20:47 ` Aleksey Kuleshov
2016-03-04 22:57 ` Andrey Smirnov
2016-03-05 0:04 ` Aleksey Kuleshov
2016-03-05 9:15 ` Antony Pavlov
2016-03-05 9:27 ` Aleksey Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304071152.GC21869@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rndfax@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox