mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Juergen Borleis <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 5/7] ARM: i.MX: karo-tx6: Setup other PMICs
Date: Fri, 4 Mar 2016 12:48:53 +0100	[thread overview]
Message-ID: <201603041248.53632.jbe@pengutronix.de> (raw)
In-Reply-To: <1456934863-30990-6-git-send-email-s.hauer@pengutronix.de>

Hi Sascha,

On Wednesday 02 March 2016 17:07:41 Sascha Hauer wrote:
> diff --git a/arch/arm/boards/karo-tx6x/pmic-rn5t567.c
> b/arch/arm/boards/karo-tx6x/pmic-rn5t567.c new file mode 100644
> index 0000000..363ffbc
> --- /dev/null
> +++ b/arch/arm/boards/karo-tx6x/pmic-rn5t567.c
> [...]
> +int rn5t567_pmic_setup(struct i2c_client *client)
> +{
> +       int ret;
> +       unsigned char value;
> +
> +       ret = i2c_read_reg(client, 0x11, &value, 1);
> +       if (ret != 1) {
> +               pr_err("i2c read error\n");
> +               return ret;
> +       }
> +
> +       ret = rn5t567_setup_regs(client, rn5t567_regs,
> +                               ARRAY_SIZE(rn5t567_regs));
> +       if (ret)
> +               return ret;
> +
> +       ret = i2c_read_reg(client, RN5T567_DC1DAC, &value, 1);
> +       if (ret == 1)
> +               pr_debug("VDDCORE set to %umV\n", regval_to_mV(value));
> +       else
> +               pr_err("i2c read error\n");
> +
> +       ret = i2c_read_reg(client, RN5T567_DC2DAC, &value, 1);
> +       if (ret == 1)
> +               pr_debug("VDDSOC  set to %umV\n", regval_to_mV(value));

In the case of a successfull init this will return '1' and barebox then prints
an annoying error message like this:

Karo-tx6: PMIC setup failed with error -1

> [...]

-- 
Pengutronix e.K.                              | Juergen Borleis             |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-03-04 11:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 16:07 [PATCH] i.MX6: Karo: Update TX6 support Sascha Hauer
2016-03-02 16:07 ` [PATCH 1/7] ARM: i.MX: karo-tx6: Factor out a common tx6 dtsi file Sascha Hauer
2016-03-02 16:07 ` [PATCH 2/7] ARM: i.MX: karo-tx6: Support eMMC board variants Sascha Hauer
2016-03-02 16:07 ` [PATCH 3/7] ARM: i.MX: karo-tx6: Add support for the i.MX6q 1GiB variant Sascha Hauer
2016-03-02 16:07 ` [PATCH 4/7] ARM: i.MX: karo-tx6: Generalize 801x support Sascha Hauer
2016-03-02 16:07 ` [PATCH 5/7] ARM: i.MX: karo-tx6: Setup other PMICs Sascha Hauer
2016-03-04 11:48   ` Juergen Borleis [this message]
2016-03-07  8:08     ` Sascha Hauer
2016-03-02 16:07 ` [PATCH 6/7] ARM: i.MX: karo-tx6: disable power button Sascha Hauer
2016-03-02 16:07 ` [PATCH 7/7] ARM: i.MX: karo-tx6: add pr_fmt Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201603041248.53632.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox