From: Sascha Hauer <s.hauer@pengutronix.de>
To: Renaud Barbier <renaud.barbier@ge.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] lib: declared buffer is too small to hold string
Date: Tue, 12 Apr 2016 08:05:49 +0200 [thread overview]
Message-ID: <20160412060549.GO9102@pengutronix.de> (raw)
In-Reply-To: <1460106970-23144-1-git-send-email-renaud.barbier@ge.com>
On Fri, Apr 08, 2016 at 10:16:10AM +0100, Renaud Barbier wrote:
> Displaying an unsigned 64-bit integer can be represented by up to 20
> characters. The 20 bytes buffer reserved to store the formatted string
> "%llu Bytes" is to small: (20 + 6) = 26. Hence, a bigger buffer is reserved
> to hold this string.
>
> Signed-off-by: Renaud Barbier <renaud.barbier@ge.com>
> ---
> lib/display_options.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/lib/display_options.c b/lib/display_options.c
> index 2d695e4..0f65f59 100644
> --- a/lib/display_options.c
> +++ b/lib/display_options.c
> @@ -26,7 +26,7 @@
> */
> char *size_human_readable(unsigned long long size)
> {
> - static char buf[20];
> + static char buf[30];
> unsigned long m = 0, n;
> unsigned long long f;
> static const char names[] = {'E', 'P', 'T', 'G', 'M', 'K'};
> --
> 1.7.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-04-12 6:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 9:16 Renaud Barbier
2016-04-12 6:05 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412060549.GO9102@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=renaud.barbier@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox