mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: tegra: set up stack before calling maincluster entry
Date: Thu, 14 Apr 2016 08:50:49 +0200	[thread overview]
Message-ID: <20160414065049.GZ9102@pengutronix.de> (raw)
In-Reply-To: <1460492120-28861-1-git-send-email-dev@lynxeye.de>

On Tue, Apr 12, 2016 at 10:15:20PM +0200, Lucas Stach wrote:
> Allows this code to work correct regardless of the used compiler
> optimizations.
> 
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
>  arch/arm/mach-tegra/include/mach/lowlevel.h | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/mach-tegra/include/mach/lowlevel.h b/arch/arm/mach-tegra/include/mach/lowlevel.h
> index f70688e..e9ba5ee 100644
> --- a/arch/arm/mach-tegra/include/mach/lowlevel.h
> +++ b/arch/arm/mach-tegra/include/mach/lowlevel.h
> @@ -255,9 +255,6 @@ void tegra_cpu_lowlevel_setup(char *fdt)
>  {
>  	uint32_t r;
>  
> -	if (tegra_cpu_is_maincomplex())
> -		tegra_maincomplex_entry(fdt - get_runtime_offset());
> -
>  	/* set the cpu to SVC32 mode */
>  	__asm__ __volatile__("mrs %0, cpsr":"=r"(r));
>  	r &= ~0x1f;
> @@ -265,6 +262,10 @@ void tegra_cpu_lowlevel_setup(char *fdt)
>  	__asm__ __volatile__("msr cpsr, %0" : : "r"(r));
>  
>  	arm_setup_stack(TEGRA_IRAM_BASE + SZ_256K - 8);
> +
> +	if (tegra_cpu_is_maincomplex())
> +		tegra_maincomplex_entry(fdt - get_runtime_offset());
> +
>  	tegra_ll_delay_setup();
>  }
>  
> -- 
> 2.5.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2016-04-14  6:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 20:15 Lucas Stach
2016-04-14  6:50 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160414065049.GZ9102@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=dev@lynxeye.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox