From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1bD3ZD-0004Wx-V4 for barebox@lists.infradead.org; Wed, 15 Jun 2016 05:40:44 +0000 Date: Wed, 15 Jun 2016 07:40:20 +0200 From: Sascha Hauer Message-ID: <20160615054020.GA9677@pengutronix.de> References: <20160614065506.25821-1-aar@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160614065506.25821-1-aar@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] ifup: remove deletion of ip env To: Alexander Aring Cc: barebox@lists.infradead.org On Tue, Jun 14, 2016 at 08:55:05AM +0200, Alexander Aring wrote: > This patch removes the deletion of ip env and changes to the behaviour > that it use previous ip=$TYPE assignments if ip env is not part of network > env which will be sourced. > > Example: > somewhere in shell: ip=dhcp > \- in case of ip=$TYPE in network env: overwrites the ip env > \- in case of NO ip=$TYPE in network env: use the ip="dhcp" from shell > > Signed-off-by: Alexander Aring > --- > Don't know if this patch breaks to much handling with previous env handling, > but I would except such handling. > > Also don't know if the example is correct or I mixed something with > global/local envs. > > Maybe apply patch 2/2 only. > > net/ifup.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/ifup.c b/net/ifup.c > index f22afc9..17e1b2f 100644 > --- a/net/ifup.c > +++ b/net/ifup.c > @@ -62,8 +62,6 @@ int ifup(const char *name, unsigned flags) > > env_push_context(); > > - setenv("ip", ""); > - Erm, no. It was intentional to *not* leak in previous settings of the ip variable to make the behaviour deterministic and not dependent on previous env settings. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox