Re: [PATCH 3/4] commands: ubi: Add ubiupdatevol command

[Sascha Hauer <s.hauer@pengutronix.de>]

On Wed, Jun 22, 2016 at 11:02:40AM +0200, Teresa Remmet wrote:
> Add ubiupdatevol command. This is to update static
> and dynamic volumes.
> 
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
>  commands/ubi.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
> 
> diff --git a/commands/ubi.c b/commands/ubi.c
> index f4ff5e7..e727776 100644
> --- a/commands/ubi.c
> +++ b/commands/ubi.c
> @@ -5,12 +5,64 @@
>  #include <ioctl.h>
>  #include <errno.h>
>  #include <getopt.h>
> +#include <libfile.h>
>  #include <linux/mtd/mtd.h>
>  #include <linux/kernel.h>
> +#include <linux/stat.h>
>  #include <linux/mtd/mtd-abi.h>
>  #include <mtd/ubi-user.h>
>  #include <mtd/ubi-media.h>
>  
> +static int do_ubiupdatevol(int argc, char *argv[])
> +{
> +	int fd_vol, ret;
> +	uint64_t size = 0;
> +	void *buf;
> +
> +	if (argc - optind < 2)
> +		return COMMAND_ERROR_USAGE;
> +
> +	buf = read_file(argv[optind+1], (size_t *) &size);
> +	if (!buf) {
> +		perror("read");
> +		return 1;
> +	}

This limits us to files that fit into memory. Is it worth it to
read/write in a loop?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox