mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org, Ronald Zachariah <rozachar@cisco.com>
Subject: Re: [PATCH] fs: ext4: fix symlink read function
Date: Thu, 7 Jul 2016 09:18:39 +0200	[thread overview]
Message-ID: <20160707071839.GB20657@pengutronix.de> (raw)
In-Reply-To: <1467835124-31201-1-git-send-email-antonynpavlov@gmail.com>

On Wed, Jul 06, 2016 at 10:58:44PM +0300, Antony Pavlov wrote:
> From: Ronald Zachariah <rozachar@cisco.com>
> 
> From U-Boot commit:
> 
> | commit 37f23885e4905ff500a8524328aa3084ac11cdb4
> | Author: Ronald Zachariah <rozachar@cisco.com>
> | Date:   Thu Apr 28 07:08:34 2016 +0200
> |
> |     fs: ext4: fix symlink read function
> |
> |     The function ext4fs_read_symlink was unable to handle a symlink
> |     which had target name of exactly 60 characters.
> |
> |     Signed-off-by: Ronald Zachariah <rozachar@cisco.com>
> |     Signed-off-by: Stefan Roese <sr@denx.de>
> |     Reviewed-by: Stephen Warren <swarren@nvidia.com>
> |     Cc: Tom Rini <trini@konsulko.com>
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  fs/ext4/ext4_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c
> index 1ecbb8d..6c4083e 100644
> --- a/fs/ext4/ext4_common.c
> +++ b/fs/ext4/ext4_common.c
> @@ -377,7 +377,7 @@ char *ext4fs_read_symlink(struct ext2fs_node *node)
>  	if (!symlink)
>  		return 0;
>  
> -	if (__le32_to_cpu(diro->inode.size) <= 60) {
> +	if (__le32_to_cpu(diro->inode.size) < sizeof(diro->inode.b.symlink)) {
>  		strncpy(symlink, diro->inode.b.symlink,
>  			 __le32_to_cpu(diro->inode.size));
>  	} else {
> -- 
> 2.8.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2016-07-07  7:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06 19:58 Antony Pavlov
2016-07-07  7:18 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160707071839.GB20657@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=rozachar@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox