From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bL3aQ-0002Wv-QC for barebox@lists.infradead.org; Thu, 07 Jul 2016 07:19:03 +0000 Date: Thu, 7 Jul 2016 09:18:39 +0200 From: Sascha Hauer Message-ID: <20160707071839.GB20657@pengutronix.de> References: <1467835124-31201-1-git-send-email-antonynpavlov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1467835124-31201-1-git-send-email-antonynpavlov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] fs: ext4: fix symlink read function To: Antony Pavlov Cc: barebox@lists.infradead.org, Ronald Zachariah On Wed, Jul 06, 2016 at 10:58:44PM +0300, Antony Pavlov wrote: > From: Ronald Zachariah > > From U-Boot commit: > > | commit 37f23885e4905ff500a8524328aa3084ac11cdb4 > | Author: Ronald Zachariah > | Date: Thu Apr 28 07:08:34 2016 +0200 > | > | fs: ext4: fix symlink read function > | > | The function ext4fs_read_symlink was unable to handle a symlink > | which had target name of exactly 60 characters. > | > | Signed-off-by: Ronald Zachariah > | Signed-off-by: Stefan Roese > | Reviewed-by: Stephen Warren > | Cc: Tom Rini > > Signed-off-by: Antony Pavlov > --- > fs/ext4/ext4_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks Sascha > > diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c > index 1ecbb8d..6c4083e 100644 > --- a/fs/ext4/ext4_common.c > +++ b/fs/ext4/ext4_common.c > @@ -377,7 +377,7 @@ char *ext4fs_read_symlink(struct ext2fs_node *node) > if (!symlink) > return 0; > > - if (__le32_to_cpu(diro->inode.size) <= 60) { > + if (__le32_to_cpu(diro->inode.size) < sizeof(diro->inode.b.symlink)) { > strncpy(symlink, diro->inode.b.symlink, > __le32_to_cpu(diro->inode.size)); > } else { > -- > 2.8.1 > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox