From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] commands: menu: check return pointer properly
Date: Thu, 7 Jul 2016 09:46:32 +0200 [thread overview]
Message-ID: <20160707074630.GF20657@pengutronix.de> (raw)
In-Reply-To: <1467833572-26162-1-git-send-email-dev@lynxeye.de>
Hi Lucas,
I applied all patches from this and the other series I haven't commented
on.
Sascha
On Wed, Jul 06, 2016 at 09:32:48PM +0200, Lucas Stach wrote:
> The called functions return error codes encoded in the pointer,
> so the NULL check will never be true.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> commands/menu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commands/menu.c b/commands/menu.c
> index 9ec2d57..e1079fd 100644
> --- a/commands/menu.c
> +++ b/commands/menu.c
> @@ -83,7 +83,7 @@ static int do_menu_entry_add(struct cmd_menu *cm)
> else
> me = menu_add_command_entry(m, cm->description, cm->command,
> cm->type);
> - if (!me)
> + if (IS_ERR(me))
> return PTR_ERR(me);
>
> me->box_state = cm->box_state > 0 ? 1 : 0;
> --
> 2.7.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-07-07 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 19:32 Lucas Stach
2016-07-06 19:32 ` [PATCH 2/5] ARM: i.MX: iim: fix potential out of bounds array access Lucas Stach
2016-07-06 19:32 ` [PATCH 3/5] ubifs: fix potential memory leak Lucas Stach
2016-07-07 7:06 ` Sascha Hauer
2016-07-06 19:32 ` [PATCH 4/5] ubifs: fix potential NULL ptr dereference Lucas Stach
2016-07-07 7:15 ` Sascha Hauer
2016-07-06 19:32 ` [PATCH 5/5] ubifs: check return pointer properly Lucas Stach
2016-07-07 7:46 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707074630.GF20657@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dev@lynxeye.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox