From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] input: Compile keymap only if necessary
Date: Mon, 11 Jul 2016 08:31:36 +0200 [thread overview]
Message-ID: <20160711063136.GX20657@pengutronix.de> (raw)
In-Reply-To: <20160704164810.ad22e9243d6bd0541a637888@gmail.com>
On Mon, Jul 04, 2016 at 04:48:10PM +0300, Antony Pavlov wrote:
> On Sun, 19 Jun 2016 20:53:33 +0300
> Alexander Shiyan <shc_work@mail.ru> wrote:
>
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > drivers/input/Makefile | 3 +--
> > include/input/keyboard.h | 4 ++++
> > 2 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/input/Makefile b/drivers/input/Makefile
> > index 7d2c194..e694a98 100644
> > --- a/drivers/input/Makefile
> > +++ b/drivers/input/Makefile
> > @@ -1,8 +1,7 @@
> > -obj-$(CONFIG_INPUT) += input.o
> > +obj-$(CONFIG_INPUT) += input.o keymap.o
> > obj-$(CONFIG_INPUT_MATRIXKMAP) += matrix-keymap.o
> > obj-$(CONFIG_KEYBOARD_USB) += usb_kbd.o
> > obj-$(CONFIG_KEYBOARD_GPIO) += gpio_keys.o
> > obj-$(CONFIG_KEYBOARD_TWL6030) += twl6030_pwrbtn.o
> > obj-$(CONFIG_KEYBOARD_IMX_KEYPAD) += imx_keypad.o
> > obj-$(CONFIG_KEYBOARD_QT1070) += qt1070.o
> > -obj-y += keymap.o
> > diff --git a/include/input/keyboard.h b/include/input/keyboard.h
> > index d1f5bf5..e205a51 100644
> > --- a/include/input/keyboard.h
> > +++ b/include/input/keyboard.h
> > @@ -1,6 +1,8 @@
> > #ifndef __INPUT_KEYBOARD_H
> > #define __INPUT_KEYBOARD_H
> >
> > +#ifdef CONFIG_INPUT
> > +
>
> Do we really need this?
Erm, no, we shouldn't need this. I removed this hunk from the patch.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-07-11 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 17:53 Alexander Shiyan
2016-06-20 6:34 ` Sascha Hauer
2016-07-04 13:48 ` Antony Pavlov
2016-07-11 6:31 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711063136.GX20657@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox