mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* problem configuring backlight brightness levels in device tree
@ 2016-07-11 11:51 giorgio.nicole
  2016-07-13  5:18 ` Sascha Hauer
  0 siblings, 1 reply; 9+ messages in thread
From: giorgio.nicole @ 2016-07-11 11:51 UTC (permalink / raw)
  To: barebox

Hi,

I was trying to configure a pwm backlight on an embedded arm board
and I think I've found a minor problem.

In the source file 'drivers/video/backlight-pwm.c', in the function pwm_backlight_parse_dt()
you set the number of brightness values to:

pwm_backlight->backlight.brightness_max = length / sizeof(u32);

and then loop through the array with:

for (i = 0; i <=  pwm_backlight->backlight.brightness_max; i++)

to find the max of the array.

I think the '<=' should be a '<' otherwise you access an uninitialized value
one past the end of the array; this actually does not directly crash barebox
but the whole brightness values are scaled wrong.

giorgio

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-07-25  8:37 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-11 11:51 problem configuring backlight brightness levels in device tree giorgio.nicole
2016-07-13  5:18 ` Sascha Hauer
2016-07-14 14:17   ` [PATCH 0/4] fixes some problems found in the backligth-pwm implementation iw3gtf
2016-07-14 14:17     ` [PATCH 1/4] video/backlight-pwm: fixed a loop index going out of range iw3gtf
2016-07-14 14:17     ` [PATCH 2/4] video/backlight-pwm: fix the value of 'brightness_max' iw3gtf
2016-07-14 14:17     ` [PATCH 3/4] video/backlight-pwm: code readability improvement iw3gtf
2016-07-14 14:17     ` [PATCH 4/4] video/backlight-pwm: properly handle the case of an empty 'brightness-levels' in the device tree iw3gtf
2016-07-15  6:07     ` [PATCH 0/4] fixes some problems found in the backligth-pwm implementation Sascha Hauer
2016-07-25  8:37     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox