mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH 2/7] mfd: syscon: Don't call request_iomem_region()
Date: Fri, 15 Jul 2016 07:53:17 +0200	[thread overview]
Message-ID: <20160715055317.GF20657@pengutronix.de> (raw)
In-Reply-To: <1468476665-26409-2-git-send-email-andrew.smirnov@gmail.com>

Alexander,

Applying 1/7 and this one should make clps711x work again, right?

Sascha

On Wed, Jul 13, 2016 at 11:11:00PM -0700, Andrey Smirnov wrote:
> On platforms that mix dedicated IP block register space with
> miscellaneous registers it is necessary to share register window between
> syscon and dedicated IP block driver. Calling request_iomem_region()
> implies exclusive ownership of the region, which, in the case above
> could not happen.
> 
> This change also makes this driver's behaviour to that of its Linux
> kernel counterpart.
> 
> Suggested-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  drivers/mfd/syscon.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index 9589a03..ac46122 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -76,12 +76,6 @@ static int syscon_probe(struct device_d *dev)
>  		return PTR_ERR(res);
>  	}
>  
> -	res = request_iomem_region(dev_name(dev), res->start, res->end);
> -	if (IS_ERR(res)) {
> -		free(syscon);
> -		return PTR_ERR(res);
> -	}
> -
>  	syscon->base = (void __iomem *)res->start;
>  	dev->priv = syscon;
>  
> -- 
> 2.5.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-07-15  5:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14  6:10 [PATCH 1/7] Revert "syscon: Decrease driver registration priority" Andrey Smirnov
2016-07-14  6:11 ` [PATCH 2/7] mfd: syscon: Don't call request_iomem_region() Andrey Smirnov
2016-07-15  5:53   ` Sascha Hauer [this message]
2016-07-15  9:11     ` Re[2]: " Alexander Shiyan
2016-07-14  6:11 ` [PATCH 3/7] mfd: syscon: Decouple syscon interface from platform devices Andrey Smirnov
2016-07-15  5:59   ` Sascha Hauer
2016-07-15 21:50     ` Andrey Smirnov
2016-07-18  6:18       ` Sascha Hauer
2016-07-14  6:11 ` [PATCH 4/7] mfd: syscon: Don't check xzalloc return for NULL Andrey Smirnov
2016-07-14  6:11 ` [PATCH 5/7] mfd: syscon: Use IOMEM instead of explicit cast Andrey Smirnov
2016-07-14  6:11 ` [PATCH 6/7] imx_thermal: Remove leftover debug output Andrey Smirnov
2016-07-14  6:11 ` [PATCH 7/7] i.MX: ocotp: Register regmap against orignal device Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160715055317.GF20657@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox