From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Kurz <akurz@blala.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] scripts: imx: const function arguments
Date: Mon, 18 Jul 2016 08:03:26 +0200 [thread overview]
Message-ID: <20160718060326.GJ20657@pengutronix.de> (raw)
In-Reply-To: <1468603396-29108-1-git-send-email-akurz@blala.de>
On Fri, Jul 15, 2016 at 07:23:16PM +0200, Alexander Kurz wrote:
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---
> scripts/imx/imx-image.c | 9 +++++----
> scripts/imx/imx-usb-loader.c | 4 ++--
> scripts/imx/imx.h | 7 ++++---
> 3 files changed, 11 insertions(+), 9 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c
> index 3f62228..c0bf9c0 100644
> --- a/scripts/imx/imx-image.c
> +++ b/scripts/imx/imx-image.c
> @@ -278,7 +278,7 @@ static int write_mem_v1(uint32_t addr, uint32_t val, int width, int set_bits, in
> * ============================================================================
> */
>
> -static int add_header_v2(struct config_data *data, void *buf)
> +static int add_header_v2(const struct config_data *data, void *buf)
> {
> struct imx_flash_header_v2 *hdr;
> int dcdsize = curdcd * sizeof(uint32_t);
> @@ -447,7 +447,8 @@ static int write_dcd(const char *outfile)
> return 0;
> }
>
> -static int check(struct config_data *data, uint32_t cmd, uint32_t addr, uint32_t mask)
> +static int check(const struct config_data *data, uint32_t cmd, uint32_t addr,
> + uint32_t mask)
> {
> if (curdcd > MAX_DCD - 3) {
> fprintf(stderr, "At maximum %d dcd entried are allowed\n", MAX_DCD);
> @@ -463,8 +464,8 @@ static int check(struct config_data *data, uint32_t cmd, uint32_t addr, uint32_t
> return 0;
> }
>
> -static int write_mem(struct config_data *data, uint32_t addr, uint32_t val, int width,
> - int set_bits, int clear_bits)
> +static int write_mem(const struct config_data *data, uint32_t addr,
> + uint32_t val, int width, int set_bits, int clear_bits)
> {
> switch (data->header_version) {
> case 1:
> diff --git a/scripts/imx/imx-usb-loader.c b/scripts/imx/imx-usb-loader.c
> index cf9d610..97ed044 100644
> --- a/scripts/imx/imx-usb-loader.c
> +++ b/scripts/imx/imx-usb-loader.c
> @@ -1239,8 +1239,8 @@ cleanup:
> return ret;
> }
>
> -static int write_mem(struct config_data *data, uint32_t addr, uint32_t val, int width,
> - int set_bits, int clear_bits)
> +static int write_mem(const struct config_data *data, uint32_t addr,
> + uint32_t val, int width, int set_bits, int clear_bits)
> {
> return modify_memory(addr, val, width, set_bits, clear_bits);
> }
> diff --git a/scripts/imx/imx.h b/scripts/imx/imx.h
> index a136958..8db7e7b 100644
> --- a/scripts/imx/imx.h
> +++ b/scripts/imx/imx.h
> @@ -65,9 +65,10 @@ struct config_data {
> char *srkfile;
> int header_version;
> int cpu_type;
> - int (*check)(struct config_data *data, uint32_t cmd, uint32_t addr, uint32_t mask);
> - int (*write_mem)(struct config_data *data, uint32_t addr, uint32_t val, int width,
> - int set_bits, int clear_bits);
> + int (*check)(const struct config_data *data, uint32_t cmd,
> + uint32_t addr, uint32_t mask);
> + int (*write_mem)(const struct config_data *data, uint32_t addr,
> + uint32_t val, int width, int set_bits, int clear_bits);
> int csf_space;
> char *csf;
> };
> --
> 2.1.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-07-18 6:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 17:23 Alexander Kurz
2016-07-18 6:03 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718060326.GJ20657@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=akurz@blala.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox