From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bP1eh-0008Ps-3f for barebox@lists.infradead.org; Mon, 18 Jul 2016 06:03:54 +0000 Date: Mon, 18 Jul 2016 08:03:26 +0200 From: Sascha Hauer Message-ID: <20160718060326.GJ20657@pengutronix.de> References: <1468603396-29108-1-git-send-email-akurz@blala.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1468603396-29108-1-git-send-email-akurz@blala.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] scripts: imx: const function arguments To: Alexander Kurz Cc: barebox@lists.infradead.org On Fri, Jul 15, 2016 at 07:23:16PM +0200, Alexander Kurz wrote: > Signed-off-by: Alexander Kurz > --- > scripts/imx/imx-image.c | 9 +++++---- > scripts/imx/imx-usb-loader.c | 4 ++-- > scripts/imx/imx.h | 7 ++++--- > 3 files changed, 11 insertions(+), 9 deletions(-) Applied, thanks Sascha > > diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c > index 3f62228..c0bf9c0 100644 > --- a/scripts/imx/imx-image.c > +++ b/scripts/imx/imx-image.c > @@ -278,7 +278,7 @@ static int write_mem_v1(uint32_t addr, uint32_t val, int width, int set_bits, in > * ============================================================================ > */ > > -static int add_header_v2(struct config_data *data, void *buf) > +static int add_header_v2(const struct config_data *data, void *buf) > { > struct imx_flash_header_v2 *hdr; > int dcdsize = curdcd * sizeof(uint32_t); > @@ -447,7 +447,8 @@ static int write_dcd(const char *outfile) > return 0; > } > > -static int check(struct config_data *data, uint32_t cmd, uint32_t addr, uint32_t mask) > +static int check(const struct config_data *data, uint32_t cmd, uint32_t addr, > + uint32_t mask) > { > if (curdcd > MAX_DCD - 3) { > fprintf(stderr, "At maximum %d dcd entried are allowed\n", MAX_DCD); > @@ -463,8 +464,8 @@ static int check(struct config_data *data, uint32_t cmd, uint32_t addr, uint32_t > return 0; > } > > -static int write_mem(struct config_data *data, uint32_t addr, uint32_t val, int width, > - int set_bits, int clear_bits) > +static int write_mem(const struct config_data *data, uint32_t addr, > + uint32_t val, int width, int set_bits, int clear_bits) > { > switch (data->header_version) { > case 1: > diff --git a/scripts/imx/imx-usb-loader.c b/scripts/imx/imx-usb-loader.c > index cf9d610..97ed044 100644 > --- a/scripts/imx/imx-usb-loader.c > +++ b/scripts/imx/imx-usb-loader.c > @@ -1239,8 +1239,8 @@ cleanup: > return ret; > } > > -static int write_mem(struct config_data *data, uint32_t addr, uint32_t val, int width, > - int set_bits, int clear_bits) > +static int write_mem(const struct config_data *data, uint32_t addr, > + uint32_t val, int width, int set_bits, int clear_bits) > { > return modify_memory(addr, val, width, set_bits, clear_bits); > } > diff --git a/scripts/imx/imx.h b/scripts/imx/imx.h > index a136958..8db7e7b 100644 > --- a/scripts/imx/imx.h > +++ b/scripts/imx/imx.h > @@ -65,9 +65,10 @@ struct config_data { > char *srkfile; > int header_version; > int cpu_type; > - int (*check)(struct config_data *data, uint32_t cmd, uint32_t addr, uint32_t mask); > - int (*write_mem)(struct config_data *data, uint32_t addr, uint32_t val, int width, > - int set_bits, int clear_bits); > + int (*check)(const struct config_data *data, uint32_t cmd, > + uint32_t addr, uint32_t mask); > + int (*write_mem)(const struct config_data *data, uint32_t addr, > + uint32_t val, int width, int set_bits, int clear_bits); > int csf_space; > char *csf; > }; > -- > 2.1.4 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox