mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] mfd mc13xxx: add MC13892_REVISION_3_6
@ 2016-07-19 20:09 Alexander Kurz
  2016-07-21  6:18 ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Alexander Kurz @ 2016-07-19 20:09 UTC (permalink / raw)
  To: barebox; +Cc: Alexander Kurz

An MC13892CJ having REV[4:0]=0x1e can be found in the kindle-d01100.
Add the revision to the list to support this device.

Signed-off-by: Alexander Kurz <akurz@blala.de>
---
 drivers/mfd/mc13xxx.c | 1 +
 include/mfd/mc13xxx.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/mfd/mc13xxx.c b/drivers/mfd/mc13xxx.c
index 68d70c5..075ec49 100644
--- a/drivers/mfd/mc13xxx.c
+++ b/drivers/mfd/mc13xxx.c
@@ -225,6 +225,7 @@ static struct __init {
 	{ 0x02, MC13892_REVISION_3_2a, "3.2a" },
 	{ 0x1b, MC13892_REVISION_3_3, "3.3" },
 	{ 0x1d, MC13892_REVISION_3_5, "3.5" },
+	{ 0x1e, MC13892_REVISION_3_6, "3.6" },
 };
 
 static int __init mc13892_revision(struct mc13xxx *mc13xxx)
diff --git a/include/mfd/mc13xxx.h b/include/mfd/mc13xxx.h
index 96a32e4..8799463 100644
--- a/include/mfd/mc13xxx.h
+++ b/include/mfd/mc13xxx.h
@@ -133,6 +133,7 @@
 #define MC13892_REVISION_3_2a		9
 #define MC13892_REVISION_3_3		10
 #define MC13892_REVISION_3_5		11
+#define MC13892_REVISION_3_6		12
 
 #define MC13783_SWX_VOLTAGE(x)		((x) & 0x3f)
 #define MC13783_SWX_VOLTAGE_DVS(x)	(((x) & 0x3f) << 6)
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] mfd mc13xxx: add MC13892_REVISION_3_6
  2016-07-19 20:09 [PATCH] mfd mc13xxx: add MC13892_REVISION_3_6 Alexander Kurz
@ 2016-07-21  6:18 ` Sascha Hauer
  2016-07-28 10:54   ` Alexander Kurz
  0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2016-07-21  6:18 UTC (permalink / raw)
  To: Alexander Kurz; +Cc: barebox

On Tue, Jul 19, 2016 at 10:09:54PM +0200, Alexander Kurz wrote:
> An MC13892CJ having REV[4:0]=0x1e can be found in the kindle-d01100.
> Add the revision to the list to support this device.
> 
> Signed-off-by: Alexander Kurz <akurz@blala.de>

Applied, thanks

Sascha

> ---
>  drivers/mfd/mc13xxx.c | 1 +
>  include/mfd/mc13xxx.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/mc13xxx.c b/drivers/mfd/mc13xxx.c
> index 68d70c5..075ec49 100644
> --- a/drivers/mfd/mc13xxx.c
> +++ b/drivers/mfd/mc13xxx.c
> @@ -225,6 +225,7 @@ static struct __init {
>  	{ 0x02, MC13892_REVISION_3_2a, "3.2a" },
>  	{ 0x1b, MC13892_REVISION_3_3, "3.3" },
>  	{ 0x1d, MC13892_REVISION_3_5, "3.5" },
> +	{ 0x1e, MC13892_REVISION_3_6, "3.6" },
>  };
>  
>  static int __init mc13892_revision(struct mc13xxx *mc13xxx)
> diff --git a/include/mfd/mc13xxx.h b/include/mfd/mc13xxx.h
> index 96a32e4..8799463 100644
> --- a/include/mfd/mc13xxx.h
> +++ b/include/mfd/mc13xxx.h
> @@ -133,6 +133,7 @@
>  #define MC13892_REVISION_3_2a		9
>  #define MC13892_REVISION_3_3		10
>  #define MC13892_REVISION_3_5		11
> +#define MC13892_REVISION_3_6		12
>  
>  #define MC13783_SWX_VOLTAGE(x)		((x) & 0x3f)
>  #define MC13783_SWX_VOLTAGE_DVS(x)	(((x) & 0x3f) << 6)
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] mfd mc13xxx: add MC13892_REVISION_3_6
  2016-07-21  6:18 ` Sascha Hauer
@ 2016-07-28 10:54   ` Alexander Kurz
  2016-08-03  5:31     ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Alexander Kurz @ 2016-07-28 10:54 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

Hi,
thanks for applying this quickly, unfortunately this patch is not 
correct.

The observed MC13892 is attached to a MC508 in two different variants of 
e-book readers. When .max_speed_hz is set faster than 16MHz (default is
20MHz since patch 6e18b3a48ee4), the device is identified as
> Found MC13892 ID: 0x0067fe [Rev: 3.6]

while indeed this device is a
> Found MC13892 ID: 0x0045d4 [Rev: 2.4]

Is it possible to drop this patch or should I post a revert patch on it?

Thanks, Alexander


On Thu, 21 Jul 2016, Sascha Hauer wrote:

> On Tue, Jul 19, 2016 at 10:09:54PM +0200, Alexander Kurz wrote:
> > An MC13892CJ having REV[4:0]=0x1e can be found in the kindle-d01100.
> > Add the revision to the list to support this device.
> > 
> > Signed-off-by: Alexander Kurz <akurz@blala.de>
> 
> Applied, thanks
> 
> Sascha
> 
> > ---
> >  drivers/mfd/mc13xxx.c | 1 +
> >  include/mfd/mc13xxx.h | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/drivers/mfd/mc13xxx.c b/drivers/mfd/mc13xxx.c
> > index 68d70c5..075ec49 100644
> > --- a/drivers/mfd/mc13xxx.c
> > +++ b/drivers/mfd/mc13xxx.c
> > @@ -225,6 +225,7 @@ static struct __init {
> >  	{ 0x02, MC13892_REVISION_3_2a, "3.2a" },
> >  	{ 0x1b, MC13892_REVISION_3_3, "3.3" },
> >  	{ 0x1d, MC13892_REVISION_3_5, "3.5" },
> > +	{ 0x1e, MC13892_REVISION_3_6, "3.6" },
> >  };
> >  
> >  static int __init mc13892_revision(struct mc13xxx *mc13xxx)
> > diff --git a/include/mfd/mc13xxx.h b/include/mfd/mc13xxx.h
> > index 96a32e4..8799463 100644
> > --- a/include/mfd/mc13xxx.h
> > +++ b/include/mfd/mc13xxx.h
> > @@ -133,6 +133,7 @@
> >  #define MC13892_REVISION_3_2a		9
> >  #define MC13892_REVISION_3_3		10
> >  #define MC13892_REVISION_3_5		11
> > +#define MC13892_REVISION_3_6		12
> >  
> >  #define MC13783_SWX_VOLTAGE(x)		((x) & 0x3f)
> >  #define MC13783_SWX_VOLTAGE_DVS(x)	(((x) & 0x3f) << 6)
> > -- 
> > 2.1.4
> > 
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] mfd mc13xxx: add MC13892_REVISION_3_6
  2016-07-28 10:54   ` Alexander Kurz
@ 2016-08-03  5:31     ` Sascha Hauer
  0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2016-08-03  5:31 UTC (permalink / raw)
  To: Alexander Kurz; +Cc: barebox

On Thu, Jul 28, 2016 at 12:54:05PM +0200, Alexander Kurz wrote:
> Hi,
> thanks for applying this quickly, unfortunately this patch is not 
> correct.
> 
> The observed MC13892 is attached to a MC508 in two different variants of 
> e-book readers. When .max_speed_hz is set faster than 16MHz (default is
> 20MHz since patch 6e18b3a48ee4), the device is identified as
> > Found MC13892 ID: 0x0067fe [Rev: 3.6]
> 
> while indeed this device is a
> > Found MC13892 ID: 0x0045d4 [Rev: 2.4]
> 
> Is it possible to drop this patch or should I post a revert patch on it?

It's still in next, so I just dropped it. You can send a corrected patch
if you wish.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-03  5:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-19 20:09 [PATCH] mfd mc13xxx: add MC13892_REVISION_3_6 Alexander Kurz
2016-07-21  6:18 ` Sascha Hauer
2016-07-28 10:54   ` Alexander Kurz
2016-08-03  5:31     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox