[PATCH] bbu: parameters are inverted in error message

[PATCH] bbu: parameters are inverted in error message

[Renaud Barbier]

The error message warning the user that the image is too big for
the device has its parameters in the wrong order. Swap the two
parameters so that the output makes sense.

Signed-off-by: Renaud Barbier <renaud.barbier@ge.com>
---
 common/bbu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/bbu.c b/common/bbu.c
index 1b22139..c5dda8c 100644
--- a/common/bbu.c
+++ b/common/bbu.c
@@ -307,8 +307,8 @@ static int bbu_std_file_handler(struct bbu_handler *handler,
 		oflags |= O_CREAT;
 	} else {
 		if (!S_ISREG(s.st_mode) && s.st_size < data->len) {
-			printf("Image (%lld) is too big for device (%zd)\n",
-					s.st_size, data->len);
+			printf("Image (%zd) is too big for device (%lld)\n",
+					data->len, s.st_size);
 		}
 	}
 
-- 
1.7.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] bbu: parameters are inverted in error message

[Sascha Hauer]

On Wed, Aug 03, 2016 at 10:53:25AM +0100, Renaud Barbier wrote:
> The error message warning the user that the image is too big for
> the device has its parameters in the wrong order. Swap the two
> parameters so that the output makes sense.
> 
> Signed-off-by: Renaud Barbier <renaud.barbier@ge.com>
> ---
>  common/bbu.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/common/bbu.c b/common/bbu.c
> index 1b22139..c5dda8c 100644
> --- a/common/bbu.c
> +++ b/common/bbu.c
> @@ -307,8 +307,8 @@ static int bbu_std_file_handler(struct bbu_handler *handler,
>  		oflags |= O_CREAT;
>  	} else {
>  		if (!S_ISREG(s.st_mode) && s.st_size < data->len) {
> -			printf("Image (%lld) is too big for device (%zd)\n",
> -					s.st_size, data->len);
> +			printf("Image (%zd) is too big for device (%lld)\n",
> +					data->len, s.st_size);
>  		}
>  	}
>  
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox