[PATCH 1/1] [PATCH] fix ARMv8 interference with ARMv7

[PATCH 1/1] [PATCH] fix ARMv8 interference with ARMv7

[Vicente Bergas]

CONFIG_CPU_V8 is checked against 'y' and 'n', but the case when the
variable is unset is not considered.
This patch only checks the variable against a single value 'y' so the
logic is always coherent even when the variable is unset.

Signed-off-by: Vicente Bergas <vicencb@gmail.com>
Tested-by: Vicente Bergas <vicencb@gmail.com>
---
 arch/arm/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 9fc3cd3..1ab35b9 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -21,7 +21,7 @@ endif
 # at least some of the code would be executed with MMU off, lets be
 # conservative and instruct the compiler not to generate any unaligned
 # accesses
-ifeq ($(CONFIG_CPU_V8),n)
+ifneq ($(CONFIG_CPU_V8),y)
 CFLAGS += -mno-unaligned-access
 endif
 
-- 
2.9.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/1] [PATCH] fix ARMv8 interference with ARMv7

[Sascha Hauer]

On Mon, Aug 08, 2016 at 01:31:43PM +0200, Vicente Bergas wrote:
> CONFIG_CPU_V8 is checked against 'y' and 'n', but the case when the
> variable is unset is not considered.
> This patch only checks the variable against a single value 'y' so the
> logic is always coherent even when the variable is unset.
> 
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> Tested-by: Vicente Bergas <vicencb@gmail.com>
> ---
>  arch/arm/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 9fc3cd3..1ab35b9 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -21,7 +21,7 @@ endif
>  # at least some of the code would be executed with MMU off, lets be
>  # conservative and instruct the compiler not to generate any unaligned
>  # accesses
> -ifeq ($(CONFIG_CPU_V8),n)
> +ifneq ($(CONFIG_CPU_V8),y)
>  CFLAGS += -mno-unaligned-access
>  endif
>  
> -- 
> 2.9.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox