* [PATCH] fix double free
@ 2016-08-17 8:52 Aleksey Kuleshov
2016-08-18 7:13 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Aleksey Kuleshov @ 2016-08-17 8:52 UTC (permalink / raw)
To: barebox; +Cc: Aleksey Kuleshov
it already gets free in bootentries_free
no need to do this in ->release method
Signed-off-by: Aleksey Kuleshov <rndfax@yandex.ru>
---
common/boot.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/common/boot.c b/common/boot.c
index a2f5a81..52e181d 100644
--- a/common/boot.c
+++ b/common/boot.c
@@ -169,7 +169,6 @@ static void bootscript_entry_release(struct bootentry *entry)
struct bootentry_script *bs = container_of(entry, struct bootentry_script, entry);
free(bs->scriptpath);
- free(bs->entry.me.display);
free(bs);
}
--
2.8.0.rc3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix double free
2016-08-17 8:52 [PATCH] fix double free Aleksey Kuleshov
@ 2016-08-18 7:13 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2016-08-18 7:13 UTC (permalink / raw)
To: Aleksey Kuleshov; +Cc: barebox
On Wed, Aug 17, 2016 at 11:52:04AM +0300, Aleksey Kuleshov wrote:
> it already gets free in bootentries_free
> no need to do this in ->release method
>
> Signed-off-by: Aleksey Kuleshov <rndfax@yandex.ru>
> ---
> common/boot.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/common/boot.c b/common/boot.c
> index a2f5a81..52e181d 100644
> --- a/common/boot.c
> +++ b/common/boot.c
> @@ -169,7 +169,6 @@ static void bootscript_entry_release(struct bootentry *entry)
> struct bootentry_script *bs = container_of(entry, struct bootentry_script, entry);
>
> free(bs->scriptpath);
> - free(bs->entry.me.display);
> free(bs);
> }
>
> --
> 2.8.0.rc3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-18 7:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-17 8:52 [PATCH] fix double free Aleksey Kuleshov
2016-08-18 7:13 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox