[PATCH] net: phy: of_phy_register_fixed_link(): drop redundant initialization

[PATCH] net: phy: of_phy_register_fixed_link(): drop redundant initialization

[Antony Pavlov]

The phy_device_create() function makes all necessary phydev initialization
so we can drop phydev->pause and phydev->link initialization in
the of_phy_register_fixed_link() function.

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 drivers/net/phy/phy.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 13b8324..7132516 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -311,8 +311,6 @@ static struct phy_device *of_phy_register_fixed_link(struct device_node *np,
 	phydev->registered = 1;
 	phydev->speed = 1000;
 	phydev->duplex = 1;
-	phydev->pause = phydev->asym_pause = 0;
-	phydev->link = 1;
 
 	return phydev;
 }
-- 
2.8.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] net: phy: of_phy_register_fixed_link(): drop redundant initialization

[Sascha Hauer]

On Thu, Aug 18, 2016 at 02:20:39PM +0300, Antony Pavlov wrote:
> The phy_device_create() function makes all necessary phydev initialization
> so we can drop phydev->pause and phydev->link initialization in
> the of_phy_register_fixed_link() function.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  drivers/net/phy/phy.c | 2 --
>  1 file changed, 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 13b8324..7132516 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -311,8 +311,6 @@ static struct phy_device *of_phy_register_fixed_link(struct device_node *np,
>  	phydev->registered = 1;
>  	phydev->speed = 1000;
>  	phydev->duplex = 1;
> -	phydev->pause = phydev->asym_pause = 0;
> -	phydev->link = 1;
>  
>  	return phydev;
>  }
> -- 
> 2.8.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox