[PATCH] scripts: imx-image: DCD check command for v2 only

[PATCH] scripts: imx-image: DCD check command for v2 only

[Alexander Kurz]

DCD check command is currently implemented for imximg v2 only.
This command may also be available for v1 as mentioned in IMX35RM as
DCD-address-type "wait/read", but due to the lack of further details
it will be not supported.

Signed-off-by: Alexander Kurz <akurz@blala.de>
---
 scripts/imx/imx-image.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c
index c0bf9c0..d0c4152 100644
--- a/scripts/imx/imx-image.c
+++ b/scripts/imx/imx-image.c
@@ -450,6 +450,11 @@ static int write_dcd(const char *outfile)
 static int check(const struct config_data *data, uint32_t cmd, uint32_t addr,
 		 uint32_t mask)
 {
+	if (data->header_version != 2) {
+		fprintf(stderr, "DCD check command is not available or "
+				"not yet implemented for this SOC\n");
+		return -EINVAL;
+	}
 	if (curdcd > MAX_DCD - 3) {
 		fprintf(stderr, "At maximum %d dcd entried are allowed\n", MAX_DCD);
 		return -ENOMEM;
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] scripts: imx-image: DCD check command for v2 only

[Sascha Hauer]

On Sun, Aug 21, 2016 at 10:16:13PM +0200, Alexander Kurz wrote:
> DCD check command is currently implemented for imximg v2 only.
> This command may also be available for v1 as mentioned in IMX35RM as
> DCD-address-type "wait/read", but due to the lack of further details
> it will be not supported.
> 
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---
>  scripts/imx/imx-image.c | 5 +++++
>  1 file changed, 5 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c
> index c0bf9c0..d0c4152 100644
> --- a/scripts/imx/imx-image.c
> +++ b/scripts/imx/imx-image.c
> @@ -450,6 +450,11 @@ static int write_dcd(const char *outfile)
>  static int check(const struct config_data *data, uint32_t cmd, uint32_t addr,
>  		 uint32_t mask)
>  {
> +	if (data->header_version != 2) {
> +		fprintf(stderr, "DCD check command is not available or "
> +				"not yet implemented for this SOC\n");
> +		return -EINVAL;
> +	}
>  	if (curdcd > MAX_DCD - 3) {
>  		fprintf(stderr, "At maximum %d dcd entried are allowed\n", MAX_DCD);
>  		return -ENOMEM;
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox